338874 - Safe Browsing alert not exposed to screenreader

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect)

Description

[Mark Pilgrim (inactive)]

The Safe Browsing overlay is not exposed to assistive technologies.  Two things need to happen:

1. The speech bubble needs to be focused when it is displayed.  This is actually important for two reasons; it will signal to screenreaders to read it, and it will move focus out of the web page which will prevent keyboard users from tabbing around the page under the stack.  We can use a -moz-user-focus: normal on the containing vbox, then get a reference to that DOM node and call its focus() method from showMessage_.

2. The speech bubble needs to be exposed as an alert.  We can use DHTML Accessibility techniques to simulate this (xhtml2:role="wairole:alert").  This does *not* mean that Firefox will be popping up an actual alert box; it will just be exposing that DOM node as an alert so that DHTML-aware screenreaders such as WindowEyes can read it properly.

I have this working on a local copy and am in the process of submitting a patch.  It would be really nice if this could go into Bon Echo alpha 3, despite the code freeze.

Comment 1

[Mark Pilgrim (inactive)]

Attachment: Expose speech bubble as alert and auto-focus

Implements as described in comment 1.

Comment 2

[Tony Chang (Google)]

Comment on attachment 222923 [details] [diff] [review]
Expose speech bubble as alert and auto-focus

You'll need sr for commit (maybe ask mconnor?)

Comment 3

[Darin Fisher]

Comment on attachment 222923 [details] [diff] [review]
Expose speech bubble as alert and auto-focus

sure, this is more of a rubberstamp sr because I don't know the first thing about these technologies.  this appears to be the kind of solution being employed elsewhere in the codebase, so i assume that "we" are all in agreement about how this is to be done ;-)

sr=darin

Comment 4

[Robert Sayre]

Checked in on trunk. Branch is closed at the moment.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Bombs away, Robert. Please land this on the branch for Alpha 3.

Comment 6

[Robert Sayre]

Landed on branch.

-----------------

Checking in browser/components/safebrowsing/content/warning-overlay.xul;
/cvsroot/mozilla/browser/components/safebrowsing/content/warning-overlay.xul,v  <--  warning-overlay.xul
new revision: 1.2.2.2; previous revision: 1.2.2.1
done
Checking in browser/components/safebrowsing/content/phishing-afterload-displayer.js;
/cvsroot/mozilla/browser/components/safebrowsing/content/phishing-afterload-displayer.js,v  <--  phishing-afterload-displayer.js
new revision: 1.1.2.3; previous revision: 1.1.2.2
done