338895 - Bookmark properties cannot be saved if you try to remove associated microsummaries

Status: RESOLVED FIXED

(Firefox Graveyard :: Microsummaries, defect, P1)

Description

[Régis Caspar]

I noticed in today build that if you open the bookmark properties dialog of a "microsummarized" bookmark and select "Don't display a Summary", the save changes button doesn't work anymore. An error is shown in JS console:
  Error: generatorURI is not defined
  Source file:  file:///I:/Program%20Files/Mozilla%20Firefox/components/nsMicrosummaryService.js
  Line: 549

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060522 Minefield/3.0a1 ID:2006052205 [cairo]

Comment 1

[u88484]

Confirmed using latest trunk, not sure if this ever worked or not.

Comment 2

[Régis Caspar]

*could* be a regression due to bug 337113

Comment 3

[Myk Melez [:myk] [@mykmelez]]

(In reply to comment #2)
> *could* be a regression due to bug 337113

Indeed, it is.  The fix is trivial; I'll attach a patch shortly.

Note that this turns out to be trunk-only, so requesting reconsideration of the blocking-firefox2 flag.

Comment 4

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: fixes fat finger flub

Here's the trivial fix for this bug.

Comment 5

[Myk Melez [:myk] [@mykmelez]]

> Note that this turns out to be trunk-only, so requesting reconsideration of 
> the blocking-firefox2 flag.

And just in case that wasn't clear, my point was just that this shouldn't block Firefox 2, since it doesn't affect the branch.

Comment 6

[Myk Melez [:myk] [@mykmelez]]

Looks like this got fixed by the fix for bug 339543.