Closed
Bug 338899
Opened 20 years ago
Closed 20 years ago
be nice to -jsconsole (no duplicate windows, no unrequested windows)
Categories
(Toolkit Graveyard :: Error Console, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.8.1beta1
People
(Reporter: zeniko, Assigned: zeniko)
Details
(Keywords: fixed1.8.1)
Attachments
(1 file, 1 obsolete file)
|
3.67 KB,
patch
|
benjamin
:
review+
mconnor
:
approval-branch-1.8.1+
|
Details | Diff | Splinter Review |
The -jsconsole command line flag is currently quite broken: (1) it's impossible to open only the JavaScript Console (missing preventDefault) and (2) running a Toolkit app with -jsconsole twice yields two console windows instead just one.
|
Assignee | |
Comment 1•20 years ago
|
||
|
||
Comment 2•20 years ago
|
||
Comment on attachment 222958 [details] [diff] [review]
fix for both issues
I do not think that -jsconsole ought to prevent the default action.
Attachment #222958 -
Flags: review?(benjamin) → review-
|
|
Assignee | |
Comment 3•20 years ago
|
||
Why not? Shouldn't it be possible to either open just the JS console (to allow manually loading XPCOM components before opening a browser window) or to additionally open the JS console from the command line without getting a second browser window? Obviously, preventing the default action still lets you open - among others - XUL windows (-chrome), http URLs (-url) or an empty browser window (-browser). But also having the choice to get none of these would be nice.
|
|
Assignee | |
Comment 4•20 years ago
|
||
Attachment #222958 -
Attachment is obsolete: true
Attachment #223848 -
Flags: review?(benjamin)
|
|
||
Updated•20 years ago
|
Attachment #223848 -
Flags: review?(benjamin) → review+
|
|
Assignee | |
Updated•20 years ago
|
Attachment #223848 -
Flags: approval-branch-1.8.1?(mconnor)
|
||
Updated•20 years ago
|
Attachment #223848 -
Flags: approval-branch-1.8.1?(mconnor) → approval-branch-1.8.1+
|
|
Assignee | |
Updated•20 years ago
|
Whiteboard: [checkin needed]
|
||
Comment 5•20 years ago
|
||
Checked in on the branch and trunk. I made a mistake in the checkin comment, I put "r=mconnor" instead of "r=bsmedberg".
mozilla/toolkit/components/console/jsconsole-clhandler.js 1.5
mozilla/toolkit/components/console/jsconsole-clhandler.js 1.3.6.2
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Target Milestone: --- → Firefox 2 beta1
Version: unspecified → 2.0 Branch
|
||
Updated•18 years ago
|
Product: Firefox → Toolkit
|
|
||
Updated•10 years ago
|
Product: Toolkit → Toolkit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•