338964 - FireFTP crashes on uploads for Linux only

Status: RESOLVED INVALID

(Core :: XPCOM, defect)

Description

[Mime Čuvalo]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.3) Gecko/20060426 Firefox/1.5.0.3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.3) Gecko/20060426 Firefox/1.5.0.3

I'm the author of FireFTP.  I have been working on the program for almost two years now.  I've finally fixed Firefox crashing on Windows but Linux is still having problems.

I think it is a low-level problem with the sockets.  I can't be sure.  It would be great if someone could investigate this as a lot of people look to FireFTP to complete the FTP experience through Mozilla.

Here's some talkback info but I can't make heads or tails of it.  It seems to just crash at random points.
http://talkback-public.mozilla.org/search/start.jsp?search=2&type=iid&id=TB18951062G
http://talkback-public.mozilla.org/search/start.jsp?search=2&type=iid&id=TB18951262X
http://talkback-public.mozilla.org/search/start.jsp?search=2&type=iid&id=TB18951784E
http://talkback-public.mozilla.org/search/start.jsp?search=2&type=iid&id=TB18951821E
http://talkback-public.mozilla.org/search/start.jsp?search=2&type=iid&id=TB18951955W
http://talkback-public.mozilla.org/search/start.jsp?search=2&type=iid&id=TB18952853H
http://talkback-public.mozilla.org/search/start.jsp?search=2&type=iid&id=TB18952883Z
http://talkback-public.mozilla.org/search/start.jsp?search=2&type=iid&id=TB18952931W
http://talkback-public.mozilla.org/search/start.jsp?search=2&type=iid&id=TB18952946M
http://talkback-public.mozilla.org/search/start.jsp?search=2&type=iid&id=TB18952979Q
http://talkback-public.mozilla.org/search/start.jsp?search=2&type=iid&id=TB18957808G
http://talkback-public.mozilla.org/search/start.jsp?search=2&type=iid&id=TB18963831Q
http://talkback-public.mozilla.org/search/start.jsp?search=2&type=iid&id=TB18963863Y

Reproducible: Always

Steps to Reproduce:
1.) Install FireFTP on Linux ( http://addons.mozilla.org/firefox/684/ )
2.) Upload a file.  (Usually happens on the first time but try uploading a couple files if necessary)
3.) Crash.

Comment 1

[Adam Guthrie]

Incident ID: 18957808
Stack Signature	js_ValidContextPointer() 02807767
Product ID	Firefox15
Build ID	2006042618
Trigger Time	2006-05-21 15:26:13.0
Platform	LinuxIntel
Operating System	Linux 2.6.12-10-386
Module	libmozjs.so + (0001dcbb)
URL visited	
User Comments	
Since Last Crash	0 sec
Total Uptime	0 sec
Trigger Reason	SIGSEGV: Segmentation Fault: (signal 11)
Source File, Line No.	/builds/tinderbox/Fx-Mozilla1.8.0/Linux_2.4.21-37.EL_Depend/mozilla/js/src/jscntxt.c, line 327
Stack Trace 	
js_ValidContextPointer()  [/builds/tinderbox/Fx-Mozilla1.8.0/Linux_2.4.21-37.EL_Depend/mozilla/js/src/jscntxt.c, line 327]
ClaimScope()  [/builds/tinderbox/Fx-Mozilla1.8.0/Linux_2.4.21-37.EL_Depend/mozilla/js/src/jslock.c, line 455]
js_GetSlotThreadSafe()  [/builds/tinderbox/Fx-Mozilla1.8.0/Linux_2.4.21-37.EL_Depend/mozilla/js/src/jslock.c, line 570]
JS_GetParent()  [/builds/tinderbox/Fx-Mozilla1.8.0/Linux_2.4.21-37.EL_Depend/mozilla/js/src/jsapi.c, line 2204]
XPCWrappedNativeScope::FindInJSObjectScope()  [/builds/tinderbox/Fx-Mozilla1.8.0/Linux_2.4.21-37.EL_Depend/mozilla/js/src/xpconnect/src/xpcwrappednativescope.cpp, line 902]
XPCConvert::NativeInterface2JSObject()  [/builds/tinderbox/Fx-Mozilla1.8.0/Linux_2.4.21-37.EL_Depend/mozilla/js/src/xpconnect/src/xpcconvert.cpp, line 1052]
XPCConvert::NativeData2JS()  [/builds/tinderbox/Fx-Mozilla1.8.0/Linux_2.4.21-37.EL_Depend/mozilla/js/src/xpconnect/src/xpcconvert.cpp, line 1390]
nsXPCWrappedJSClass::CallMethod()  [/builds/tinderbox/Fx-Mozilla1.8.0/Linux_2.4.21-37.EL_Depend/mozilla/js/src/xpconnect/src/xpcwrappedjsclass.cpp, line 1256]
nsXPCWrappedJS::CallMethod()  [/builds/tinderbox/Fx-Mozilla1.8.0/Linux_2.4.21-37.EL_Depend/mozilla/js/src/xpconnect/src/xpcwrappedjs.cpp, line 462]
PrepareAndDispatch()  [/builds/tinderbox/Fx-Mozilla1.8.0/Linux_2.4.21-37.EL_Depend/mozilla/xpcom/reflect/xptcall/src/md/unix/xptcstubs_gcc_x86_unix.cpp, line 100]
nsInputStreamPump::OnStateTransfer()  [/builds/tinderbox/Fx-Mozilla1.8.0/Linux_2.4.21-37.EL_Depend/mozilla/netwerk/base/src/nsInputStreamPump.cpp, line 440]
nsInputStreamPump::OnInputStreamReady()  [/builds/tinderbox/Fx-Mozilla1.8.0/Linux_2.4.21-37.EL_Depend/mozilla/netwerk/base/src/nsInputStreamPump.cpp, line 341]
nsInputStreamReadyEvent::EventHandler()
PL_HandleEvent()  [/builds/tinderbox/Fx-Mozilla1.8.0/Linux_2.4.21-37.EL_Depend/mozilla/xpcom/threads/plevent.c, line 689]
PL_ProcessPendingEvents()  [/builds/tinderbox/Fx-Mozilla1.8.0/Linux_2.4.21-37.EL_Depend/mozilla/xpcom/threads/plevent.c, line 623]
nsEventQueueImpl::ProcessPendingEvents()  [/builds/tinderbox/Fx-Mozilla1.8.0/Linux_2.4.21-37.EL_Depend/mozilla/xpcom/threads/nsEventQueue.cpp, line 421]
event_processor_callback()  [/builds/tinderbox/Fx-Mozilla1.8.0/Linux_2.4.21-37.EL_Depend/mozilla/widget/src/gtk2/nsAppShell.cpp, line 67]
libglib-2.0.so.0 + 0x4b31c (0xb79cd31c)
libglib-2.0.so.0 + 0x244ee (0xb79a64ee)
libglib-2.0.so.0 + 0x274f6 (0xb79a94f6)
libglib-2.0.so.0 + 0x277e3 (0xb79a97e3)
libgtk-x11-2.0.so.0 + 0x11de65 (0xb7c4fe65)
nsAppShell::Run()  [/builds/tinderbox/Fx-Mozilla1.8.0/Linux_2.4.21-37.EL_Depend/mozilla/widget/src/gtk2/nsAppShell.cpp, line 141]
nsAppStartup::Run()  [/builds/tinderbox/Fx-Mozilla1.8.0/Linux_2.4.21-37.EL_Depend/mozilla/toolkit/components/startup/src/nsAppStartup.cpp, line 151]
XRE_main()  [/builds/tinderbox/Fx-Mozilla1.8.0/Linux_2.4.21-37.EL_Depend/mozilla/toolkit/xre/nsAppRunner.cpp, line 2353]
main()  [/builds/tinderbox/Fx-Mozilla1.8.0/Linux_2.4.21-37.EL_Depend/mozilla/browser/app/nsBrowserApp.cpp, line 62]
libc.so.6 + 0x14ec2 (0xb74d8ec2)

Comment 2

[Mime Čuvalo]

This should be fixed now in version 0.93 of FireFTP.

The problem was this:
this.dataTransport.setEventSink(this.progressEventSink, null);

http://www.xulplanet.com/references/xpcomref/ifaces/nsITransport.html#method_setEventSink
Setting the second parameter to null meant the notifications would happen on any thread.

So the fix was to do this:
this.threadService = Components.classes["@mozilla.org/thread;1"].getService                          (Components.interfaces.nsIThread);
this.eventQueueService = Components.classes["@mozilla.org/event-queue-service;1"].getService             (Components.interfaces.nsIEventQueueService);
this.eventQueue = this.eventQueueService.createFromIThread(this.threadService.currentThread, true);

this.dataTransport.setEventSink(this.progressEventSink, this.eventQueue);


You may close this bug.

Comment 3

[Adam Guthrie]

Marking as INVALID since it wasn't a problem in Mozilla code.

Comment 4

[timeless]

fwiw, this is really a duplicate of some xpconnect (not xpcom, please note the distinction including the fact that your stack mostly references xpconnect not xpcom) bug i have.