Closed Bug 339104 Opened 18 years ago Closed 18 years ago

Any event listener inside a repeat crashes 1_8_0

Categories

(Core Graveyard :: XForms, defect)

defect
Not set
critical

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: allan, Assigned: smaug)

References

()

Details

(Keywords: fixed1.8.0.5, fixed1.8.1)

Attachments

(2 files)

With the sync from bug 339087, any event listener inside repeat content makes firefox (1_8_0) crash on exit. For example:

<xf:repeat nodeset="x">
  <xf:message ev:event="foo-bar" level="modal">
  </xf:message>
</xf:repeat>
Attached file Testcase (crasher)
On exit, this crashes on 1_8_0. At least on localhost. Let's see if it does from bugzilla too...
Is this bug 330526?
(In reply to comment #2)
> Is this bug 330526?

It is. Aïe, why has it not been brought to 1_8_0?

*** This bug has been marked as a duplicate of 330526 ***
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → DUPLICATE
I'm opening this because we can have a workaround for 1.8
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Attached patch proposed patchSplinter Review
Allan, could you test this with 1.8.x branch.
When I took out the patch for 330526, I could reproduce the
crash also in trunk but this patch helped for that.
Assignee: allan → Olli.Pettay
Status: REOPENED → ASSIGNED
Attachment #223183 - Flags: review?
And note, RemoveModelFromDocument() is not needed in nsXFormsModelElement::OnDestroyed() because it is already 
called in nsXFormsModelElement::WillChangeDocument
Attachment #223183 - Flags: review? → review?(allan)
(In reply to comment #5)
> Created an attachment (id=223183) [edit]
> proposed patch
> 
> Allan, could you test this with 1.8.x branch.
> When I took out the patch for 330526, I could reproduce the
> crash also in trunk but this patch helped for that.

It fixes 1_8_0! Say joy!!

But could you include the same fix-approach for the focus listener in contextcontainer too? I fear that it might lead to the same crash one day.
Comment on attachment 223183 [details] [diff] [review]
proposed patch

(In reply to comment #7)
> (In reply to comment #5)
> > Created an attachment (id=223183) [edit]
> > proposed patch
> > 
> > Allan, could you test this with 1.8.x branch.
> > When I took out the patch for 330526, I could reproduce the
> > crash also in trunk but this patch helped for that.
> 
> It fixes 1_8_0! Say joy!!
> 
> But could you include the same fix-approach for the focus listener in
> contextcontainer too? I fear that it might lead to the same crash one day.

Ah, got it. It was not because we did not remove the listener, but when we did it.

Thanks Olli!

r=me
Attachment #223183 - Flags: review?(allan) → review+
Attachment #223183 - Flags: review?(doronr)
Attachment #223183 - Flags: review?(doronr) → review+
Status: ASSIGNED → RESOLVED
Closed: 18 years ago18 years ago
Resolution: --- → FIXED
Whiteboard: xf-to-branch
Keywords: fixed1.8.1
Keywords: fixed1.8.0.5
Whiteboard: xf-to-branch
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: