Closed
Bug 339117
Opened 18 years ago
Closed 17 years ago
Thunderbird needs an equivalent of about:license
Categories
(Thunderbird :: General, defect)
Thunderbird
General
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: gerv, Assigned: philor)
References
Details
(Keywords: verified1.8.1.3)
Attachments
(1 file, 1 obsolete file)
107.18 KB,
patch
|
mscott
:
review+
mscott
:
approval-thunderbird2+
|
Details | Diff | Splinter Review |
For Firefox, on the trunk and the Firefox 2.0 branch, we have all the code licensing information in about:licence, which references a local file. However, Thunderbird doesn't have a copy of this page, or any obvious access mechanism even if it did. So, we need to ship license.html with Thunderbird, and also have one or more of the following access points: - Item on the Help menu - Text in the Help (except all Thunderbird's Help appears to be web-based) - Link to click from About box Unless we opened the HTML page from disk in the system browser, then we'd need a fairly chromeless window with a scrollbar to show the licensing page in. Gerv
Comment 1•18 years ago
|
||
I prefer the last option, having a link in the about dialog for viewing the license. The link would open the local license file in the default browser. I would rather not have a top level menu item under Help for viewing the license. My two cents anyway :)
Reporter | ||
Comment 2•18 years ago
|
||
OK - about dialog link it is. :-) Gerv
Assignee | ||
Comment 3•18 years ago
|
||
There's already a link in the about dialog, end of the credits. If you make heroic efforts to activate it (I can't seem to click it, but I can focus it and then press enter), it opens an external protocol request dialog that wants to use the <unknown> application, and when you do, opens a completely blank dialog with just Cancel and OK buttons. And since license.xhtml gathered up notices that we are required to reproduce, I assume it was just oversight that this isn't blocking 2.0?
Flags: blocking-thunderbird2?
Assignee | ||
Comment 4•17 years ago
|
||
This is evil, but failing a happy resolution to bug 367718, it works (on Linux, and Mac: if someone wanted to test on Windows, that would be wonderful).
Reporter | ||
Comment 5•17 years ago
|
||
It is evil, but you are right, license is much better than no license. I won't object as long as you file follow-up bugs about reuniting the license.html files. :-) Gerv
Reporter | ||
Updated•17 years ago
|
Attachment #252301 -
Flags: review?(mscott)
Comment 6•17 years ago
|
||
Comment on attachment 252301 [details] [diff] [review] Fork Do we have to worry about l10n with license.html? Our string freeze was quite some time ago (December 4th) I think. Or do we not localize the license file?
Reporter | ||
Comment 7•17 years ago
|
||
Scott: I don't think we localise it. Certainly, no-one's ever asked me questions about which bits to do. All of the licences are only authoritative in the original language anyway. Also, I'm not sure that "we didn't include the correct licensing information because we weren't able to translate it" is a defensible position legally :-) Gerv
Comment 8•17 years ago
|
||
Comment on attachment 252301 [details] [diff] [review] Fork Phil, if i'm understanding this patch correctly, we might need to add LICENSE.html in the packaging file for the windows installer: http://lxr.mozilla.org/mozilla/source/mail/installer/windows/packages-static#69
Assignee | ||
Comment 9•17 years ago
|
||
Right you are: I finally managed to partly resurrect a Windows build environment, and I wasn't getting into the installer. I also picked up the bug 369747 link to the source (yay for forks!), and for variety's sake patched against 1.8 this time (there's incompatible context in aboutDialog.css). I've still got a tiny bit of hope I'll pull a more obviously right patch for bug 367718 out of my hat in time and land that instead, but it won't hurt to have this already (actually working and) reviewed in case.
Assignee: gerv → philringnalda
Attachment #252301 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #254713 -
Flags: review?(mscott)
Attachment #254713 -
Flags: approval-thunderbird2?
Attachment #252301 -
Flags: review?(mscott)
Comment 10•17 years ago
|
||
Comment on attachment 254713 [details] [diff] [review] Forking branch, v.2 thanks for doing all this Phil.
Attachment #254713 -
Flags: review?(mscott)
Attachment #254713 -
Flags: review+
Attachment #254713 -
Flags: approval-thunderbird2?
Attachment #254713 -
Flags: approval-thunderbird2+
Updated•17 years ago
|
Flags: blocking-thunderbird2? → blocking-thunderbird2+
Comment 11•17 years ago
|
||
Phil our new deadine for tb2 final is a week from today (03/06) should we check this in or wait for Bug 367718?
Assignee | ||
Comment 12•17 years ago
|
||
Probably right: it amused me to wait right up until my deadline reprieve yesterday, but practically speaking it's already pretty much too late. I'll land it tonight.
Assignee | ||
Comment 13•17 years ago
|
||
mail/app/Makefile.in 1.67, 1.46.2.5 mail/base/content/aboutDialog.css 1.6, 1.4.4.1 mail/base/content/credits.xhtml 1.16, 1.4.2.10 mail/installer/windows/packages-static 1.37, 1.8.2.23 mail/license.html 1.1, 1.1.2.1
Reporter | ||
Comment 14•17 years ago
|
||
Works for me :-) Thanks, Phil, for making this happen. Gerv
Status: RESOLVED → VERIFIED
Comment 15•17 years ago
|
||
verified fixed for 1.8.1.3 with Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.1.3) Gecko/20070326 Thunderbird/2.0.0.0 Mnenhy/0.7.5.0 ID:2007032620, about :license works for me - adding verified keyword
Keywords: fixed1.8.1.3 → verified1.8.1.3
You need to log in
before you can comment on or make changes to this bug.
Description
•