339275 - move on manual junk broken on local folders in new profile

Status: RESOLVED WORKSFORME

(Thunderbird :: Mail Window Front End, defect)

Description

[Tuukka Tolvanen (sp3000)]

move on manual junk broken on local folders in new profile

05-12 build, new profile test3:
1. new profile, dummy pop, global inbox, throw in an inbox with some messages
2. in tools -> junk settings -> local: move junk to junk on local
3. in tools -> junk settings -> local: when manual junk, move
4. mark a message as junk
-> message moved to junk folder; OK.

05-21 build, new profile test4:
1. new profile, dummy pop, global inbox, throw in an inbox with some messages
2. in account settings -> popacct -> junk settings: move junk to junk on local
3. in options -> privacy -> junk: when manual junk, move
4. mark messages as junk
-> messages not moved to junk folder; FAIL.

05-21 build, profile test5 clone of test3:
1. mark message as junk
-> message not moved to junk folder; ?
2. in account settings -> popacct -> junk settings: move junk to junk on local
3. in options -> privacy -> junk: when manual junk, move
4. mark message as junk
-> messages moved to junk folder; OK.

Relevant-looking pref diffs:

    pref diffs test3 (old) -> test4 (new)

-user_pref("mail.server.server1.manualMark", true);
-user_pref("mail.server.server1.moveOnSpam", true);
-user_pref("mail.server.server1.serverFilterName", "SpamAssassin");
-user_pref("mail.server.server1.spamActionTargetAccount", "mailbox://nobody@Local%20Folders");
-user_pref("mail.server.server1.spamActionTargetFolder", "mailbox://nobody@Local%20Folders/Junk");
+user_pref("mail.server.server2.moveOnSpam", true);
+user_pref("mail.spam.manualMark", true);
+user_pref("mail.spam.version", 1);

    pref diffs test3 (old) -> test5 (old+new)

+user_pref("mail.server.server2.moveOnSpam", true);
+user_pref("mail.spam.manualMark", true);
+user_pref("mail.spam.version", 1);

    pref diffs test4 (new) -> test5 (old+new)

+user_pref("mail.server.server1.manualMark", true);
+user_pref("mail.server.server1.moveOnSpam", true);
+user_pref("mail.server.server1.serverFilterName", "SpamAssassin");
+user_pref("mail.server.server1.spamActionTargetAccount", "mailbox://nobody@Local%20Folders");
+user_pref("mail.server.server1.spamActionTargetFolder", "mailbox://nobody@Local%20Folders/Junk");

Looks like the new stuff from bug 257990 doesn't set the necessary prefs so they apply to the Local Folders account; possibly a hint of bug 299826 there too.

Comment 1

[Tuukka Tolvanen (sp3000)]

oh, and, of course the steps taken with 05-12 and 05-21 aren't quite equivalent since I'm setting junk prefs on Local Folders in 05-12 and on the pop account in 05-21; but there's no ui for junk settings for Local Folders in 05-21 that I can find.

Comment 2

[Mike Cowperthwaite]

> Looks like the new stuff from bug 257990 doesn't set the necessary prefs so
> they apply to the Local Folders account

Part of that bug involved an automatic port of  ..server1.manualMark  (first account's "move on manual mark" setting) to the global  mail.spam.manualMark  pref -- so I think that part of the diffs can be ignored.

In the test3-vs-test5 diff, using an "old" profile (created with software prior to the fix from 257990), there were two steps involved in changing the prefs: the porting to "spam.version = 1" and the manual changes you made at test5 
steps 2 and 3.  I think the critical difference is the addition of:
  user_pref("mail.server.server2.moveOnSpam", true)  
It seems that with the new changes, the 'server2' (POP account) needs to have moveOnSpam set, even if the message is in  Local Folders/Inbox  -- something that wasn't necessary before "spam.version=1".

Comment 3

[Tuukka Tolvanen (sp3000)]

If I have a bunch of POP accounts deferred to Local Folders, and have a bunch of messages from different incoming accounts in Local Folders' Inbox, and I mark them as junk, is it expected that those messages may go to different folders or go nowhere depending on which incoming account they came from? Or is it expected that the Local Folders account should have its own junk move prefs also, such that a message may go to a different junk folder depending on whether it's moved by junk analysis when received, or by manual marking as junk? Would it make sense to have deferred accounts use the junk move prefs of their deferred-to account, instead?

Comment 4

[Mike Cowperthwaite]

xref bug 217528

Comment 5

[Mike Cowperthwaite]

I believe this has been fixed by the patch for bug 351545.

Comment 6

[Tuukka Tolvanen (sp3000)]

That patch did not change the failing behavior. Between then and now, however, Junk Settings have been added for Local Folders in Account Settings, and enabling "Move new junk messages" there corrects the behavior; I'd say that's good enough -> wfm