Closed Bug 339370 Opened 15 years ago Closed 15 years ago

Scrollbars in popup windows appear inactive (Carbon)

Categories

(Core Graveyard :: Widget: Mac, defect)

1.8 Branch
PowerPC
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.8.1beta1

People

(Reporter: mark, Assigned: mark)

References

Details

(Keywords: fixed1.8.1)

Attachments

(1 file)

After bug 54488, scrollbars in popup windows have an inactive appearance.  Testcase: autocomplete dropdown.  This is because popup windows are seen by the window manager (OS) as inactive.
Attached patch PatchSplinter Review
The restructuring at the end of the method is because I wanted to get rid of the magic numbers.  Apple gives us enums in anonymous enums, so gcc warns of a type mismatch if they're in a condition ? k1 : k2 construct.
Attachment #223485 - Flags: review?(joshmoz)
Summary: Scrollbars in popup windows appear inactive → Scrollbars in popup windows appear inactive (Carbon)
Attachment #223485 - Flags: review?(joshmoz) → review+
Checked in on trunk.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Comment on attachment 223485 [details] [diff] [review]
Patch

Will consolidate with 54488 checkin on 1.8 branch once it's proven.
Attachment #223485 - Flags: approval-branch-1.8.1?(mark)
Comment on attachment 223485 [details] [diff] [review]
Patch

Checked in on MOZILLA_1_8_BRANCH (consolidated patch including the branch
version of this patch, bug 54488, and bug 339482 on bug 54488).
Attachment #223485 - Flags: approval-branch-1.8.1?(mark) → approval-branch-1.8.1+
Keywords: fixed1.8.1
Product: Core → Core Graveyard
Version: Trunk → 1.8 Branch
You need to log in before you can comment on or make changes to this bug.