Closed Bug 339371 Opened 18 years ago Closed 18 years ago

Need [NSApp run] on the stack

Categories

(Core :: Widget: Cocoa, defect)

PowerPC
macOS
defect
Not set
major

Tracking

()

RESOLVED FIXED

People

(Reporter: mark, Assigned: mark)

References

Details

Attachments

(2 files)

When we're running under Cocoa, we should make sure to run with [NSApp run] beneath us on the stack.  Josh and I are seeing weird crashes otherwise.  Testcase: attempt to log in to an https site that uses http authentication.
Attached patch FixSplinter Review
Attachment #223490 - Flags: review?(joshmoz)
Attachment #223490 - Flags: review?(joshmoz) → review+
Attachment #223490 - Flags: superreview?(darin)
Attachment #223490 - Flags: superreview?(darin) → superreview+
Attached file crash on quit
I am still seeing weird crashes with this patch (I've been using it all day).
I wonder if this is caused by running after terminate (if the terminate you see on the stack isn't the first terminate) - in that case, I have a patch...somewhere...that might help...
*** Bug 339942 has been marked as a duplicate of this bug. ***
Checked in on the trunk.  May need more work (see comment 2).
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Depends on: 340453
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: