339383 - Make Bugzilla::Group use Bugzilla::Object

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, enhancement)

Description

[Max Kanat-Alexander]

Comment 1

[Max Kanat-Alexander]

Attachment: v1

Okay, this is a relatively simple patch, it should be fairly easy to review. It's mostly just deleting code.

Comment 2

[Max Kanat-Alexander]

Attachment: v1.1

Oh, there was a small error in the POD. Fixed in this patch.

Comment 3

[Olav Vitters]

Comment on attachment 231913 [details] [diff] [review]
v1.1

>Index: Bugzilla/Group.pm

>-sub get_all_groups {
>-    my $dbh = Bugzilla->dbh;
>-
>-    my $group_ids = $dbh->selectcol_arrayref('SELECT id FROM groups
>-                                              ORDER BY isbuggroup, name');

The get_all from Bugzilla::Object does not sort by isbuggroup first, causing the editgroups.cgi interface and editflagtypes.cgi to look ugly.

Rest of the patch was good.

Comment 4

[Max Kanat-Alexander]

Attachment: v1.2

Okay, that was an easy fix. :-) I just added a LIST_ORDER constant in Bugzilla::Group.

Comment 5

[Max Kanat-Alexander]

/cvsroot/mozilla/webtools/bugzilla/editflagtypes.cgi,v  <--  editflagtypes.cgi
new revision: 1.45; previous revision: 1.44
done
Checking in editgroups.cgi;
/cvsroot/mozilla/webtools/bugzilla/editgroups.cgi,v  <--  editgroups.cgi
new revision: 1.79; previous revision: 1.78
done
Checking in Bugzilla/Group.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Group.pm,v  <--  Group.pm
new revision: 1.15; previous revision: 1.14
done
Checking in Bugzilla/Config/GroupSecurity.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config/GroupSecurity.pm,v  <--  GroupSecurity.pm
new revision: 1.8; previous revision: 1.7
done