339483 - Anti-Phishing fails after opening preferences

Status: RESOLVED WORKSFORME

(Toolkit :: Safe Browsing, defect)

Description

[dex_sf]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1a3) Gecko/20060526 BonEcho/2.0a3
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1a3) Gecko/20060526 BonEcho/2.0a3

After opening the preferences once on a PPC with Mac OS X 10.4.6 the Anti-Phishing test site isn't recognized as potential threat anymore until you restart Bon Echo.

Reproducible: Always

Steps to Reproduce:
1. start Bon Echo,
2. open Preferences
3. go to http://www.google.com/tools/firefox/safebrowsing/phish-o-rama.html

Actual Results:  
Anti-Phishing test site isn't recognized as potential threat.

Expected Results:  
Anti-Phishing should recognize the test site and come up with the alert.

Comment 1

[Patrick]

Could it not simply be that if you visited the site once, and been warned about it, yet decided to continue, that it will not warn you again?

For me, going there, and not doing anything with the dialog, just closing the tab, opening preferences, and going to that page again results in a warning both times.

FWIW: i had also observed this behavior you described a few days ago.

Comment 2

[dex_sf]

@ Patrick:

Nope, I didn't make any choice but went back to http://www.mozilla.org/projects/bonecho/anti-phishing/ right after the warning appeared the first time. Then I clicked on the link to the test site once more and the warning came up again. Then I went back to the Anti-Phishing Info page, opened preferences, closed it again with any modifications and clicked on the test site link, but no warning appeared anymore.

Everything was tested on a new, clean profile.

Dex

Comment 3

[dex_sf]

that was supposed to mean "...closed it [Preferences] again without any modifications..."

Sorry!!

Dex

Comment 4

[Ria Klaassen (not reading all bugmail)]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1a2) Gecko/20060524 BonEcho/2.0a2
I see always a warning, opening options window makes no difference if I don't change the settings for the feature. 

Comment 5

[dex_sf]

@ Ria: I don't see the problem on my Win XP system either, only on the Mac.

Dex

Comment 6

[Jo Hermans]

confirmed in alpha 3, on Mac OS X 10.2.8

Opening the preferences windows stops the save browsing extension. But I also also provoke the error by ope3ning the Javascript Console.

Because of this, it might be related to bug 339416, which reports a JS-error every time the console is opened.

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

cc'ing tony, dunno if you automatically get safebrowsing bugs
also cc'ing vlad, on the off chance that it's related to bug 338786

Comment 8

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

(In reply to comment #7)
> cc'ing tony, dunno if you automatically get safebrowsing bugs
> also cc'ing vlad, on the off chance that it's related to bug 338786

Shouldn't be; I see the problem described here on windows (that is, there's no forgery alert) -- the canvas bug is mac-only.

Comment 9

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

(In reply to comment #8)
> (In reply to comment #7)
> > cc'ing tony, dunno if you automatically get safebrowsing bugs
> > also cc'ing vlad, on the off chance that it's related to bug 338786
> 
> Shouldn't be; I see the problem described here on windows (that is, there's no
> forgery alert) -- the canvas bug is mac-only.

I'm lying; I don't see this on windows. (I saw it in my own build, which apparently had some sb bug baked in.  Works fine with a3 under windows.)

So, it could be related to 338786, but I think that would just prevent the canvas area from drawing; the bubble should still be coming up, I think, unless there's an exception being thrown somewhere.  I'm working on fixing 338786 now, so hopefully we should know soon (I need to reproduce 338786 in my own builds first, though, still having problems doing that).

Comment 10

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: What I see

Ugh.  In my own build where canvas supposedly "works", this is what I see.  So it may well be related to the canvas issue.

Comment 11

[Mike Connor [:mconnor]]

-> vlad, since I think he's already working on this.

Comment 12

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Fixed by my canvas fixes.

Comment 13

[:Gavin Sharp [email: [e-mail]]]

Fixed on the branch by bug 338786.