Closed
Bug 339485
Opened 18 years ago
Closed 18 years ago
Document Alt+(Up|Down) and F4 shortcuts in search box
Categories
(Firefox Graveyard :: Help Documentation, defect)
Firefox Graveyard
Help Documentation
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 2 beta1
People
(Reporter: jwalden+fxhelp, Assigned: steffen.wilberg)
References
Details
(Keywords: fixed1.8.1)
Attachments
(1 file)
1.70 KB,
patch
|
jwalden+fxhelp
:
review+
steffen.wilberg
:
approval-branch-1.8.1+
|
Details | Diff | Splinter Review |
They trigger the popdown containing installed engines. I don't know when the shortcuts were implemented, but it looks like they were fixed to work in bug 337720 a week and a half ago. There's a part of me that wants to remove the Ctrl+Up/Down shortcuts from docs since the performed action is significantly less intuitive (the user has to rememeber the order of the installed engines) and replace them with the shortcuts this bug requests. (There's also a part of me that wants to request Ctrl+Up/Down be *completely* removed, but I'm less sure this .) Thoughts?
Comment 1•18 years ago
|
||
These shortcuts were originally implemented in bug 283273 for Firefox 1.5. For some reason I thought they were already documented... maybe I'm thinking of something else.
Assignee | ||
Comment 2•18 years ago
|
||
Yeah, let's just s/Accel+Up Arrow/Alt+Up Arrow/ and the same for Down Arrow. Nice to see a sign of life from you again, Jeff. I hope you've got a bit more time now since I've got patches waiting in bug 325690 and bug 335779, and more work to do for Firefox 2.
Assignee | ||
Comment 3•18 years ago
|
||
Merges "Select Previous Search Engine" and "Select Next Search Engine" to "Select or Manage Search Engines". Also fixes bug 336462.
Assignee: nobody → steffen.wilberg
Status: NEW → ASSIGNED
Attachment #224256 -
Flags: review?(jwalden+fxhelp)
Reporter | ||
Comment 4•18 years ago
|
||
Comment on attachment 224256 [details] [diff] [review] patch Looks fine to me, r=me.
Attachment #224256 -
Flags: review?(jwalden+fxhelp) → review+
Assignee | ||
Updated•18 years ago
|
Attachment #224256 -
Flags: approval-branch-1.8.1+
Assignee | ||
Comment 5•18 years ago
|
||
Checked in trunk & branch.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Target Milestone: Firefox 2 → Firefox 2 beta1
Updated•8 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•