339557 - Updater: timestamp of installed files doesn't restored

Status: RESOLVED WONTFIX

(Toolkit :: Application Update, defect)

Description

[Arkady Belousov]

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows 98; ru) Opera 8.54
Build Identifier: http://mozilla.mirrors.tds.net/pub/mozilla.org/thunderbird/releases/1.5.0.2/win32/ru/Thunderbird%20Setup%201.5.0.2.exe

After installation, timestamp of installed files is the same, as time of creation of this file on this machine.

Reproducible: Always

Comment 1

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

(In reply to comment #0)
> After installation, timestamp of installed files is the same, as time of
> creation of this file on this machine.

Lack of information for >1.5 years -> incomplete.

Comment 2

[Arkady Belousov]

> Lack of information for >1.5 years -> incomplete.

     Which more information you need? I think, anything is clear.

PS: After changing installer, some issues (including this one) disappear, but now this issue remains in updater. See, what I see after installer:

xpistub      dll¦ 12400¦14.02.08¦17:32
thunderbird  exe¦8285 К¦14.02.08¦17:32
updater      exe¦132232¦14.02.08¦17:32

But if TB was updated through updater (I do this 29 february), then I see:

xpistub      dll¦ 12400¦29.02.08¦01:47
thunderbird  exe¦8285 К¦29.02.08¦01:47
updater      exe¦132232¦29.02.08¦01:47

PPS: Because bug is gone from installer, then I now change summary from "Installer: timestamp of installed files doesn't restored" to "Updater: ...".

Comment 3

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Wayne, thoughts?

Comment 4

[Wayne Mery (:wsmwk)]

I no nothing about installer stuff, in part because I don't pay attention to any of it and I haven't educated myself - so I'm of no help with these. Even less about updater. Sorry.

Comment 5

[Arkady Belousov]

     I think, this is very easy to fix issue - both distribute and updates are archives, which store file timestamp for each file. When unpacking file, its timestamp should be restored. But, as I understand, someone who was wrote installer and who do wrote updater (by using 3rd party library for dealing with archive or wroting his own), forgets to get timestamp from file header in archive (where stored also file name, CRC, etc) and call function, to set this timestamp for file after its unpacking.

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

AFAICT the mar format does not store the file modification time,
 https://wiki.mozilla.org/Software_Update:MAR

Comment 7

[Robert Strong (they/them - no direct email)]

No justification has been made as to why this is needed and without that the additional data stored, work to add this, and work performed by the updater isn't worth the time to implement. Closing as wontfix.