Closed
Bug 339726
Opened 19 years ago
Closed 19 years ago
Internal-API getter_Copies should work with nsString
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha1
People
(Reporter: benjamin, Assigned: benjamin)
Details
Attachments
(1 file)
|
1.24 KB,
patch
|
darin.moz
:
review+
|
Details | Diff | Splinter Review |
Currently the external-API getter_Copies works with nsString, but the internal-API doesn't. That's making it slightly difficult to port code around.
|
Assignee | |
Comment 1•19 years ago
|
||
I don't really know how to move .Adopt() up to nsTAString, and this fixes the problem at hand.
Attachment #223827 -
Flags: review?(darin)
|
||
Comment 2•19 years ago
|
||
Comment on attachment 223827 [details] [diff] [review]
Safe and simple, rev. 1
Replace nsTString_CharT with nsTSubstring_CharT at least since that is where Adopt is defined.
You can implement nsTAString Adopt by having it call nsTSubstring Adopt in the case where the nsTAString is one of ours, else you can failover to calling Assign and then free the given buffer.
r=darin with the change to nsTSubstring_CharT at least
Attachment #223827 -
Flags: review?(darin) → review+
|
|
Assignee | |
Comment 3•19 years ago
|
||
Fixed on trunk with nsTSubstring_CharT
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•