please include a whitespace after #include before the next token

NEW
Assigned to

Status

Core Graveyard
Java APIs for DOM
12 years ago
6 years ago

People

(Reporter: timeless, Assigned: Ashu Kulkarni)

Tracking

Trunk
x86
Windows XP

Firefox Tracking Flags

(Not tracked)

Details

(URL)

(Reporter)

Description

12 years ago
http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/java/plugins/src/List.cpp&rev=1.2&mark=16
http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/java/plugins/src/PlugletsDir.cpp&rev=1.7&mark=21
http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/java/dom/jni/org_mozilla_dom_events_EventImpl.cpp&rev=1.12&mark=25-28
http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/java/dom/jni/nativeDOMProxyListener.cpp&rev=1.5&mark=22-28

http://landfill.mozilla.org/mxr-test/mozilla/search?string=include%3C&find=%5C.cpp%24&filter=

Found one matching line
include<
/java/dom/jni/nativeDOMProxyListener.cpp, line 22 -- #include<stdio.h> 

http://landfill.mozilla.org/mxr-test/mozilla/search?string=%23include%22&find=%5C.cpp%24

 Found 13 matching lines
#include"
/java/plugins/src/List.cpp, line 16 -- #include"List.h"
/java/plugins/src/PlugletsDir.cpp, line 21 -- #include"PlugletsDir.h"
/java/dom/jni/org_mozilla_dom_events_EventImpl.cpp, line 25 -- #include"nsIDOMEvent.h"
/java/dom/jni/org_mozilla_dom_events_EventImpl.cpp, line 26 -- #include"nsIDOMNSEvent.h"
/java/dom/jni/org_mozilla_dom_events_EventImpl.cpp, line 27 -- #include"nsIDOMEventTarget.h"
/java/dom/jni/org_mozilla_dom_events_EventImpl.cpp, line 28 -- #include"javaDOMEventsGlobals.h"
/java/dom/jni/org_mozilla_dom_events_UIEventImpl.cpp, line 23 -- #include"javaDOMEventsGlobals.h"
/java/dom/jni/nativeDOMProxyListener.cpp, line 23 -- #include"prlog.h"
/java/dom/jni/nativeDOMProxyListener.cpp, line 24 -- #include"nativeDOMProxyListener.h"
/java/dom/jni/nativeDOMProxyListener.cpp, line 25 -- #include"nsIDOMNode.h"
/java/dom/jni/nativeDOMProxyListener.cpp, line 26 -- #include"nsIDOMEventTarget.h"
/java/dom/jni/nativeDOMProxyListener.cpp, line 27 -- #include"nsIDOMEventListener.h"
/java/dom/jni/nativeDOMProxyListener.cpp, line 28 -- #include"javaDOMEventsGlobals.h"


Yes I know this is mostly a bug in my tool (I fixed the bug before i found the instances in mozilla.org cvs and then used the public mxr-test to find out how few people used the less than nice style), personally I'd rather people use the standard form of #include which includes a whitespace token after |include|, clearly the majority of mozilla.org code agrees.
Component: Java APIs for DOM → Java APIs for DOM
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.