339846 - ALT key + click on XPI files triggers download and installation window at the same time.

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Patrick]

1. Go to a page with an XPI file, for instance
https://addons.mozilla.org/firefox/1865/
2. ALT click on a the "Install Now" link
3. The XPI file triggers both a direct download to the computer and the installation window for the XPI.

This is incorrect. ALT click should only trigger the direct download, not the installation.

I'm seeing this with Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20060531 Minefield/3.0a1,

but this has happened for as long as i can remember, for whatever that means, don't ask ;)

Comment 1

[Simon Bünzli]

That's rather an issue with AMO which automatically initiates an installation on any click. DUPE?

Comment 2

[Phil Ringnalda (:philor)]

Well, a combination of bug 151142 and that AMO's handler needs to filter for modifier keys since we're not likely to stop firing onclick for modified clicks any time soon.

Comment 3

[alanjstr]

I'd say that this is bug 151142 then.

Comment 4

[Cameron]

(In reply to comment #3)
> I'd say that this is bug 151142 then.
> 

I concur.

*** This bug has been marked as a duplicate of 151142 ***

Comment 5

[Phil Ringnalda (:philor)]

Hmm. So you're saying that adding |if (aEvent.altKey||aEvent.metaKey) return true;| to install.js's install() would be too much bother? Or that you think joki will come back to work for MoCo and fix that bug after four years?

In general, I'd just dupe to bug 151142 and be done with it, rather than trying to get someone to work around our rough spots, but in this case, I'm tempted to reopen and move to TechEvang to get someone to try to get you to put in a one-liner.

Comment 6

[Phil Ringnalda (:philor)]

D'oh. Forget I mentioned event.metaKey, it's altKey on Mac too.

So, 43 characters including whitespace, to not make what you know is 100% of your browser market look broken. You can see it in action and working fine at http://dev.philringnalda.com/amo/

Comment 7

[Phil Ringnalda (:philor)]

Attachment: fix

Comment 8

[Wil Clouser [:clouserw]]

Comment on attachment 226996 [details] [diff] [review]
fix

(In reply to comment #7)
> Created an attachment (id=226996) [edit]
> fix
> 

This works in windows and mac.  Just for completeness sake, I'd like to here some confirmation from someone in linux.  If you're in linux, drop by here quickly and let me know if it works:

https://update-staging.mozilla.org/~clouser/amo/v2/public/htdocs/firefox/1865

Note that update-staging isn't in the trusted list by default, so you won't get the install popup by default (just the yellow bar).

If no one checks this by the time I'm back to my home machine, I'll check it then.

Thanks.  In the mean time, I'll take the first-review request

Comment 9

[alanjstr]

ALT + click in linux seems to want to move the entire window.

Comment 10

[Adam Guthrie]

You can change that behavior in System > Preferences > Windows on GNOME. I did this, and now Alt + click on the install link does nothing.

Comment 11

[Phil Ringnalda (:philor)]

Dunno why Adam's browser remains broken even after he tells his OS to keep its dirty mitts off Alt+click, but for me that test page works fine in Linux.

Adam: does just that link fail to respond to Alt+click, or does it not work for you for any link?

Comment 12

[Adam Guthrie]

Ah, apparently every link fails to respond when I hold down Alt and click it (on trunk). This works fine on branch, though, so r=me for this working on Linux.

Comment 13

[Wil Clouser [:clouserw]]

> Dunno why Adam's browser remains broken even after he tells his OS to keep its
> dirty mitts off Alt+click, but for me that test page works fine in Linux.

Ok, firstly, the alt+click and alt+rightclick stuff is the best thing ever. ;)

And secondly, this is committed to cvs, so I'm resolving the bug. Thanks for the patch.