339872 - when there is only one anti-phishing provider, use a label, instead of a disabled menulist

Status: RESOLVED WONTFIX

(Firefox :: Settings UI, defect, P1)

Description

[(not reading, please use [e-mail] instead)]

when there is only one anti-phishing provide, use a label, instead of a disabled menulist

I'm really liking the anti-phishing / safe browsing feature, but I have a question with the pref UI.

If there is only one provider, why are we showing a disabled menulist, with one item?

To make things look better, what about doing this:

if there is only one provider, hide the disabled menulist and change the second radio button label text to be "By asking Google".  We'd accomplish this by adding another property like:

and then getting the provider name and using that to format and set the label text.

we could add something like:

safeBrowsingRemoteFormat=By asking %S

to mozilla/browser/locales/en-US/chrome/browser/preferences/preferences.properties

The logic for hiding the menulist and setting the label would be done in browser/components/preferences/advanced.js, I think.

Note, we would still need the exiting menulist and the existing dtd entry:

<!ENTITY safeBrowsingRemote.label       "By asking:">

in mozilla/browser/locales/en-US/chrome/browser/preferences/advanced.dtd as they would be used when we have multiple remote providers.

I'll attach a screen shot of the UI as it is now, and how it could look when there is one provider.

Comment 1

[(not reading, please use [e-mail] instead)]

Attachment: current UI

Comment 2

[(not reading, please use [e-mail] instead)]

Attachment: mockup (using the almighty DOM inspector, thank you joe hewitt!)

Comment 3

[Ryan Flint [:rflint] (ping via IRC for reviews)]

The current UI was only a temporary measure until we gain the ability to specify additional data providers. If you'd prefer (and to avoid duplicating our efforts), I could roll these changes into my fix for bug 339258.

Comment 4

[(not reading, please use [e-mail] instead)]

> The current UI was only a temporary measure until we gain the ability to
> specify additional data providers. If you'd prefer (and to avoid duplicating
> our efforts), I could roll these changes into my fix for bug 339258.

I'm all for avoiding duplication of effort and avoiding CVS conflicts.

If you could add into your fix for #339258 this "if there is only one provider, use a dynamic label / hide the menulist", that would be great!

Should I just re-assign to you and make this block on #339258?

Comment 5

[Ryan Flint [:rflint] (ping via IRC for reviews)]

(In reply to comment #4)
> If you could add into your fix for #339258 this "if there is only one provider,
> use a dynamic label / hide the menulist", that would be great!

Will do.
 
> Should I just re-assign to you and make this block on #339258?
Done :)

Comment 6

[(not reading, please use [e-mail] instead)]

> Done :)

Thanks for taking this one from me, Ryan.

Comment 7

[Steffen Wilberg]

I thought you used the disabled menulist to show that there ought to be other anti-phishing providers in the future and we've not completely sold Firefox to Google?

Comment 8

[Mike Connor [:mconnor]]

In shipping releases of Firefox, we will always offer a choice of multiple providers.  Marking WONTFIX.  If we ever end up shipping a single provider, we will cross this bridge then.

Comment 9

[(not reading, please use [e-mail] instead)]

what about adding the property ("safeBrowsingRemoteFormat=By asking %S") just in case we don't get a second anti-phishing provider in time?

we're still before the l10n freeze for 2.0 b1.  it would mean an additional string for the localizers to localize, and it would be unused once we have a second provider, but it does give us a backup plan.