340014 - /who should accept more than one parameter

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, enhancement)

Description

[:Gijs (he/him)]

So as to support filtering.

/who 0 o would give you a list of opers, except that it doesn't work because we drop the last parameter, after which it will pretty much spam your ... off with all non-invisible users in private channels (or something similar).

/quote WHO 0 o doesn't work because we use a special flag (pendingWhoReply) to decide whether we want to do anything with /who type replies (352 and related codes).

I'm not sure what exactly we should be doing (if not just sending everything and not caring about syntax). I'm also not sure why we're not displaying replies anyway (I can tell from the code what we're doing, just not sure why the code was written like that). Depending on reasons and documentation (if existing), I'll see what I do with it, maybe some time this weekend. If anyone else wants to have a bash, please do.

Comment 1

[:Gijs (he/him)]

Bleh, bugzilla detects branch versions now? :|

Comment 2

[:Gijs (he/him)]

Attachment: Patch

Patch.

r? -> Silver

Comment 3

[James Ross]

Comment on attachment 224314 [details] [diff] [review]
Patch

r=silver

We block who replies normally because they are considered an internal and not very useful to the user thing. The Data Manager would clear that up.

Comment 4

[James Ross]

Checked in --> FIXED.