Assignee: nobody → general
Product: Firefox → Core
QA Contact: general → general
Version: unspecified → Trunk
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows XP → All
Priority: -- → P3
Hardware: PC → All
Target Milestone: --- → mozilla1.9alpha
Created attachment 225638 [details] [diff] [review] Fix If we fail to fold the attribute name, we currently aren't able to properly fold the attribute value. Fixing this is not trivial (it'll require making the code generator understand what's going on) and is generally more work than is worth it.
Assignee: general → mrbkap
Status: NEW → ASSIGNED
Attachment #225638 - Flags: review?(brendan)
Comment on attachment 225638 [details] [diff] [review] Fix Add the traditional /* FALL THROUGH */ comment and r=me. Thanks for fixing this, /be
Attachment #225638 - Flags: review?(brendan) → review+
Attachment #225638 - Flags: approval-branch-1.8.1?(brendan)
Comment on attachment 225638 [details] [diff] [review] Fix Actually, this is a regression from an earlier 1.8.0.x release, do we want this patch (or the patch with the added comment) on that branch?
Comment on attachment 225638 [details] [diff] [review] Fix Dan, I'd like to urge you to take this regression fix for 220.127.116.11. It's safe, and given that, we should try to upgrade people away from the regression ASAP. /be
Attachment #225638 - Flags: approval-branch-1.8.1?(brendan) → approval-branch-1.8.1+
Fix checked into trunk.
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
(and the 1.8 branch)
Comment on attachment 225638 [details] [diff] [review] Fix Approved for 1.8.0 checkin, a=jay for drivers
Fix checked into the 1.8.0 branch.
Checking in regress-340024.js; /cvsroot/mozilla/js/tests/e4x/Expressions/regress-340024.js,v <-- regress-340024.js initial revision: 1.1
I can verify that this has been fixed in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:18.104.22.168) Gecko/20060620 Firefox/22.214.171.124
Status: RESOLVED → VERIFIED
Keywords: fixed126.96.36.199, fixed1.8.1 → verified188.8.131.52, verified1.8.1
You need to log in before you can comment on or make changes to this bug.