340028 - Rendering problem in <svg:image> on intel macs

Status: VERIFIED FIXED

(Core :: SVG, defect)

Description

[Amos Hayes]

When an image is loaded via <svg:image>, it is not rendered correctly.

<http://www.croczilla.com/svg/samples/circles2/circles2.xml>

Comment 1

[Amos Hayes]

Sorry. I should have explicitly mentioned in the description that I am refering to a problem on intel macs and have seen the problem on the following browsers when running without rosetta:

Camino Version 2006060104 (1.0+)
Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.0.4) Gecko/20060508 Firefox/1.5.0.4
Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1a3) Gecko/20060526 BonEcho/2.0a3

Comment 2

[Mark Mentovai]

This bug is a followup to bug 327744.

Comment 3

[Amos Hayes]

Adding Jay and Josh since they were also involved in sorting out bug 327744.

Comment 4

[Jay Patel [:jay]]

Amos: Did you mean to cc another Jay?  Because I don't think I'll be much help here (I'm the QA/Talkback guy). ;-)

Comment 5

[Amos Hayes]

Pleased to meet you Jay. I'm a relatively new bugzilla participant. My interest in some parts of Firefox stems from having a lab of intel macs & people who are trying to build an online atlas that uses Firefox SVG quite heavily. :)

Sorry about the CC out of the blue. There are a couple of these mac&intel&svg bugs left and since you seemed to be involved in triage on bug 327744, I thought maybe you'd want to see this one as well. I'd love to see all the endian bugs solved for some 1.5.0.x version of Firefox in the not too distant future. Unfortunately, my capacity at the moment is to log bugs and produce testcases.

Anyway, if there is interest/capacity to automate SVG rendering tests, I'd be happy to help create a few SVG files for a testsuite.

Comment 6

[tor]

Attachment: untested branch patch for os-x intel svg:image

Comment 7

[Josh Aas]

Attachment: unpatched croc screenshot

Without the patch tor just posted, the croc looks like this.

Comment 8

[Josh Aas]

Attachment: patched croc screenshot

with tor's patch, this is what the croc looks like

Comment 9

[tor]

Attachment: tested branch intel os-x svg:image patch

Not pretty, but I'd prefer to do the minimal amount of change to the code logic on the branch.

Comment 10

[Amos Hayes]

Thanks for the new patch tor. I have tested this patch on the MOZILLA_1_8_0 branch using the universal build instructions at:

http://developer.mozilla.org/en/docs/Mac_OS_X_Universal_Binaries

plus the following additions to the .mozconfig:

ac_add_options --enable-canvas
ac_add_options --enable-svg

and confirm that the circles2.xml crockzilla example now renders properly on intel mac. I also tried setting my build to "Open using Rosetta" and confirm that the circles2.xml test case still works there too.

Comment 11

[Daniel Veditz [:dveditz]]

Please get landed on trunk and 1.8 branch (after module owner approval, which I guess could be tor himself) for verification, then ask for 1.8.0.5 approval. Code freeze is approaching fast...

Comment 12

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Comment on attachment 225289 [details] [diff] [review]
tested branch intel os-x svg:image patch

181=shaver

Comment 13

[tor]

Checked in on MOZILLA_1_8_BRANCH.

Comment 14

[Daniel Veditz [:dveditz]]

Comment on attachment 225289 [details] [diff] [review]
tested branch intel os-x svg:image patch

approved for 1.8.0 branch, a=dveditz for drivers

Comment 15

[tor]

Checked in on MOZILLA_1_8_0_BRANCH.

Comment 16

[tor]

Checked in on trunk.

Comment 17

[juan becerra [:juanb]]

Verified using test images provided, on: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.0.5) Gecko/20060619 Firefox/1.5.0.5

Macbook Pro, MacOS X 10.4.6

Image is now rendered as it is in the Wintel version.