340036 - script tag should support version 1.7

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[Bob Clary [:bc] (inactive)]

It should be possible to request that a script only be run if JavaScript1.7 is supported either through the language or type attributes:

<script language="javascript1.7"></script>
<script type="text/javascript;version=1.7"></script>

Comment 1

[Bob Clary [:bc] (inactive)]

Attachment: patch

I think this will do it. Note that there appears to be a bug in nsJSEnvironment.cpp in that it is missing JSVERSION_1_6.

Comment 2

[Bob Clary [:bc] (inactive)]

Mark, this patch contains a tweak to dom/src/base/nsJSEnvironment.cpp that we might have caught if we had tested the dom agnostic branch using the js test library as well as the dom.

Comment 3

[Bob Clary [:bc] (inactive)]

Comment on attachment 225683 [details] [diff] [review]
patch

Peter, Johnny: this touches a little dom stuff. Can you r/sr please so I can get this in for testing?

Comment 4

[Brendan Eich [:brendan]]

Comment on attachment 225683 [details] [diff] [review]
patch

I can sr in lieu of jst, who is honeymooning.

/be

Comment 5

[Bob Clary [:bc] (inactive)]

Checking in dom/src/base/nsJSEnvironment.cpp;
/cvsroot/mozilla/dom/src/base/nsJSEnvironment.cpp,v  <--  nsJSEnvironment.cpp
new revision: 1.284; previous revision: 1.283
Checking in js/src/jsapi.c;
/cvsroot/mozilla/js/src/jsapi.c,v  <--  jsapi.c
new revision: 3.271; previous revision: 3.270
done
Checking in js/src/jspubtd.h;
/cvsroot/mozilla/js/src/jspubtd.h,v  <--  jspubtd.h
new revision: 3.60; previous revision: 3.59
done

Comment 6

[Bob Clary [:bc] (inactive)]

I know I filed this bug, and checked it in, but I use it regularly and it works so I am verifying it to get it off my to be verified list.