340064 - Autodiscovery icon tooltip for a single feed should be "Subscribe to 'Title'"

Status: RESOLVED WONTFIX

(Firefox Graveyard :: RSS Discovery and Preview, defect, P3)

Description

[Phil Ringnalda (:philor)]

(Split out of bug 337694)

When there are multiple autodiscovered feeds for a page (e.g., http://www.mozilla.org/) the tooltip for the addressbar icon is "Subscribe to this page..." and clicking gives a popup menu with "Subscribe to 'Feed title'" items for each feed, but for a single autodiscovered feed the tooltip is still just "Subscribe to this page...".

Even in the worst case, with the title from the autodiscovery <link> being "RSS", we wouldn't lose anything by having the tooltip be "Subscribe to 'RSS'...", and in cases like the URL field, particularly if you turn off feed preview so you're going directly to subscribing in your aggregator, it would be nice to have a hint that you are subscribing to that entry and its comments, rather than to the feed for the weblog as you typically are from a single entry. For the really cunning, it would also mitigate bug 304807.

Comment 1

[Phil Ringnalda (:philor)]

Attachment: Fix v.1

Comment 2

[Asaf Romano (gone)]

Comment on attachment 227039 [details] [diff] [review]
Fix v.1

r=mano, asking beltzner for ui-review.

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 227039 [details] [diff] [review]
Fix v.1

I really wish that the defaults for so many platforms didn't suck so hard. I think what we really want here is:

* if the title is < 10 characters, then make the tooltip "Subscribe to '%S' web feed ..."

* else, "Subscribe to '%S' ..."

Comment 4

[Phil Ringnalda (:philor)]

Agreed (with some fuzz: I think < 9 gets the longest, "RSS 0.92" and "Atom 0.3"); what's more, the tooltip for multiple feeds needs to change too, since our expectation is that if we aren't picking one from multiple formats, then they are distinct feeds, not feeds of "this page."

But, both of those things are late-l10n, where my original approach wouldn't have been: retargeting to Fx 3. 

Comment 5

[Phil Ringnalda (:philor)]

Bah, this was filled with wrongness: FeedHandler.harvestFeeds() doesn't run until the icon is clicked, at which point the three discovered feeds may turn out to only be three different versions of the same feed in its opinion, so we'd be giving bad cues about how many there would be. Claiming to depend on bug 304807, since I think that's a more likely place to rewrite autodiscovery to harvest as we discover.

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Currently, the tooltip behaves as follows:
- single feed on the page, https://wiki.mozilla.org/Main_Page  
-- Tooltip still says "Subscribe to this page . . ." with no other information till you click on the rss icon.

- multiple feeds on the page, http://decafbad.com/blog/2011/01/15/what-happened-to-feed-autodiscovery-in-firefox-4 
-- Tooltip says "Subscribe to this page. . ." just as it does for a page with a single feed. 
-- When the rss icon is clicked, dropdown options pop up as in the attachment "tooltip-rss-autodiscovery-multiple-feeds.png" . Each option has a separate title tooltip.

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Attachment: Behavior of rss autodiscovery button and tooltips

Comment 8

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

The feed preview code has been removed by bug 1477669.