34007 - XUL change in cookies and Images prefs dialog

Status: VERIFIED FIXED

(SeaMonkey :: Preferences, defect, P3)

Description

[Matthew Mastracci]

The cookies and images prefs dialog specifies flex="1" for the boxes surrounding
the buttons, causing extra whitespace in the button to be added in some cases
(where the description text above it spans only a single line).   This can be
fixed by removing the attribute.  

I'm not totally sure if the behaviour of flex="1" on the <box> element in this
case actually constitutes a bug, however (is this what it should do?).  The
effect it has, whether proper or not, is a bug.

I've included a context diff below:

*** pref-cookies.xul    Thu Mar 30 18:24:00 2000
--- pref-cookies2.xul   Thu Mar 30 18:23:49 2000
***************
*** 93,99 ****
                                </html:label>
        </html:div>

!     <box align="horizontal">
        <spring flex="1"/>
        <titledbutton value="&viewCookies.label;" class="dialog push"
onclick="viewCookies();"/>
      </box>
--- 93,99 ----
                                </html:label>
        </html:div>

!     <box align="horizontal" flex="1">
        <spring flex="1"/>
        <titledbutton value="&viewCookies.label;" class="dialog push"
onclick="viewCookies();"/>
      </box>
***************
*** 141,147 ****
                                </html:label>
        </html:div>

!     <box align="horizontal">
        <spring flex="1"/>
        <titledbutton value="&viewImages.label;" class="dialog push"
onclick="viewImages();"/>
      </box>
--- 141,147 ----
                                </html:label>
        </html:div>

!     <box align="horizontal" flex="1">
        <spring flex="1"/>
        <titledbutton value="&viewImages.label;" class="dialog push"
onclick="viewImages();"/>

Comment 1

[Gervase Markham [:gerv]]

[e-mail] - are you still seeing this problem with recent builds of 
Mozilla? If so, we'll get this bug confirmed.

Gerv

Comment 2

[Matthew Mastracci]

Looks like it's been fixed...  The code has been changed since this bug was

posted.  I tried resizing the window to make the cookies text a single line and

it seemed to be working fine.  I'm going to resolve this bug as "fixed".

Comment 3

[sairuh (rarely reading bugmail)]

yes, prefs overall have been coming along quite nicely, gui-wise. verif.