340104 - Move Bugzilla::Auth::get_netaddr() in Util.pm

Status: RESOLVED FIXED

(Bugzilla :: User Accounts, defect)

Description

[Frédéric Buclin]

http://www.justdave.net/bugzilladeps.png shows that we have a Bugzilla::Auth - Bugzilla::Auth::*::Cookie dependency loop because they need get_netaddr(), which is actually in Auth.pm. This routine should be moved into Util.pm.

Comment 1

[Frédéric Buclin]

Attachment: patch, v1

Comment 2

[Dave Miller [:justdave]]

Holding approval because this patch exposed a problem in the script that generates that dependency graph, and I want to fix the graph while we have a documented case of it to test the script against.  I'll hopefully have that solved in the next couple hours.

Comment 3

[Dave Miller [:justdave]]

graph script is fixed.  have fun.

Comment 4

[Frédéric Buclin]

Checking in Bugzilla/Auth.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Auth.pm,v  <--  Auth.pm
new revision: 1.17; previous revision: 1.16
done
Checking in Bugzilla/Util.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Util.pm,v  <--  Util.pm
new revision: 1.46; previous revision: 1.45
done
Checking in Bugzilla/Auth/Login/Cookie.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Auth/Login/Cookie.pm,v  <--  Cookie.pm
new revision: 1.3; previous revision: 1.2
done
Checking in Bugzilla/Auth/Persist/Cookie.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Auth/Persist/Cookie.pm,v  <--  Cookie.pm
new revision: 1.3; previous revision: 1.2
done