34014 - if XPInstall err occurs during install, report err & stop install

Status: VERIFIED FIXED

(SeaMonkey :: Installer, defect, P1)

Description

[Cathleen]

During installation phase, if any XPInstall error occurs, Mac Install Wizard 
need to report the error, and stops installation process.

Comment 1

[Samir Gehani]

Ambitiously targeting M16.

Comment 2

[Cathleen]

need to stop installation, if any error occurs.

Comment 3

[leger]

Putting on [nsbeta2+][5/16] radar.  This is a feature MUST complete work by 
05/16 or we may pull this feature for PR2.

Comment 4

[Samir Gehani]

This is *not* a feature.  It's a bug.  Moving to M17.

Comment 5

[leger]

Agreed  - a bug...not a feature.  But putting on [nsbeta2-] radar. Not critical 
to beta2.  Unless something very bad happens here?

Comment 6

[Samir Gehani]

PDT,
To respond: the very bad thing that may happen here is that the user may 
perceive that the installation was fine when in fact the product is only half 
installed.  This mystery will cause tremendous tech support headaches.  
Renominating.

Comment 7

[Samir Gehani]

General error handling is in the installer now.  Takes care of part of this bug.

Comment 8

[Michael La Guardia]

putting on nsbeta2- radar

Comment 9

[dales]

I have encountered what appears to be one form of this bug in the Mac build for
8/29.  If there is insufficient disk space to do the install, the installer
leaves the impression that installation was successful although only a partial
installation was actually done.

I must agree that support people are really, really going to appreciate NOT
having to deal with failure of the installer to give proper error feedback to
the users.

	Dale

Comment 10

[Asa Dotzler [:asa]]

updating mac mozilla installer QA contact to me

Comment 11

[timeless]

helpwanted!

Marking dataloss because I expect things like dataloss or crashes to occur.

Comment 12

[Samir Gehani]

Removing dataloss keyword.  I don't see how the user loses data in this case.  
If the installer doesn't install a zippy successfully (no crash, please note), 
then the user simply has an incomplete installation.  If you are considering the 
upgrade case, the installer is not built to be an upgarde solution -- merely a 
first time install solution.

Comment 13

[Blake Ross]

This is dataloss in a way. The user thinks they got all the files they were 
installing, but in reality they only got some of them.

Comment 14

[Samir Gehani]

Peer reviewed fix in hand.  Will seek super review once this flips to nsbeta3+
status.

Comment 15

[Daniel Veditz [:dveditz]]

Raising priority and nominating nsbeta3+. People will assume mozilla is fine 
when in fact there could be serious problems.

Comment 16

[Samir Gehani]

Attachment: Patch file 1 of 2

Comment 17

[Samir Gehani]

Attachment: Patch file 2 of 2

Comment 18

[Samir Gehani]

Sent for review to Syd.

Comment 19

[Phil Peterson]

PDT agrees P1

Comment 20

[Samir Gehani]

Fix checked in.

Comment 21

[Grace Bush]

verified