340165 - session restore not firing after crash

Status: VERIFIED INVALID

(Firefox :: Tabbed Browser, defect)

Description

[Tracy Walker [:tracy]]

seen on Bon echo nightly build from 20060602

-use crash in bug 340133 to crash browser.

on restart no session restore dialog appears

Comment 1

[Dietrich Ayala (:dietrich)]

Hi Tracy,

I was able to reproduce this on XP. However, the session-restore prompt *does* work when restarting after force-quitting the app. This means that the crash is occurring after the quit-application notification.

Rob, is there any later point at which session-restore could hook in?

Comment 2

[Mike Connor [:mconnor]]

The only thing that's really after quit-application is zpcom-shutdown, iirc.

So, if we've passed quit-application* under what circumstances does this matter?  Does the restore every time action still work?  If so, this is a WONTFIX, since restoring the session you've already chosen to discard by exiting the app isn't what we want here.

Clearing blocking nomination for now, since I think this is not a problem unless it hoses the restart after extension install case, for example.  If it does, pleaes renominate!

Comment 3

[Simon Bünzli]

(In reply to comment #2)
> So, if we've passed quit-application* under what circumstances does this
> matter?  Does the restore every time action still work?

Once quit-application is passed, from SessionStore's point of view Firefox has shut down regularly (which includes either saving the session for resuming or discarding the session file). It'd probably be easier to ensure Firefox not crashing after quit-application than to have SessionStore kick in after /every/ crash... ;-)

BTW: The same issue happens if Firefox crashes right at the start, because SessionStore doesn't set the "running" bit until after several seconds.

Comment 4

[Mike Connor [:mconnor]]

So, if we don't have useful data to restore, or have already passed the "yes I want to quit" point of shutdown, I don't think restoring the session.