340186 - -mail doesn't work without a parameter

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[[e-mail]]

If you start suiterunner with -mail -addressbook only the address book opens.
From reading the code I guess the same bug affects Thunderbird.

Comment 1

[[e-mail]]

Attachment: Proposed patch

Patch includes:
* #ifdefs to remove -options option from suite
* #ifdef to remove .eml handling from suite

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 224306 [details] [diff] [review]
Proposed patch

This works, but using the general.startup.mail pref I still get the following assertion (although the window does appear):

************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "'Illegal value' when calling method: [nsICommandLine::handleFlagWithParam]"  nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame :: file:///opt/mozmaster/mozilla/sm2/dist/bin/components/nsBrowserContentHandler.js :: handle :: line 387"  data: no]
************************************************************

I don't get this when starting up with -mail.

Comment 3

[[e-mail]]

(In reply to comment #2)
>This works, but using the general.startup.mail pref I still get the following
>assertion (although the window does appear):
Unfortunately this is an XPConnect limitation; the general startup code needs to throw an exception to propagate a failure code to HandleFlagWithParam.

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 224306 [details] [diff] [review]
Proposed patch

I haven't looked at all of this yet, but just so I don't forget:

nsMessengerBootstrap::Handle(nsICommandLine* aCmdLine)
 {
   nsresult rv;
-  PRBool found;

Thunderbird still needs this variable.

Comment 5

[[e-mail]]

Yeah, I'll add it back but inside the #ifndef block.

Comment 6

[Mark Banner (:standard8)]

(In reply to comment #2)
> (From update of attachment 224306 [details] [diff] [review] [edit])
> This works, but using the general.startup.mail pref I still get the following
> assertion (although the window does appear):
> 
> ************************************************************
> * Call to xpconnect wrapped JSObject produced this error:  *
> [Exception... "'Illegal value' when calling method:
> [nsICommandLine::handleFlagWithParam]"  nsresult: "0x80070057
> (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame ::
> file:///opt/mozmaster/mozilla/sm2/dist/bin/components/nsBrowserContentHandler.js
> :: handle :: line 387"  data: no]
> ************************************************************
> 
> I don't get this when starting up with -mail.
> 
I don't appear to get this now, so I guess it may have been something in my build (I've rebuilt since).

Comment 7

[Mark Banner (:standard8)]

Comment on attachment 224306 [details] [diff] [review]
Proposed patch

r=me with the tb compile error fixed.

Comment 8

[[e-mail]]

Attachment: Fixed patch

Comment 9

[[e-mail]]

Fix checked in.