Build Breakage in security/psm/lib/protocol/newproto.c

VERIFIED INVALID

Status

Core Graveyard
Security: UI
P3
major
VERIFIED INVALID
18 years ago
a year ago

People

(Reporter: Pascal Hofstee, Assigned: Bob Lord)

Tracking

1.0 Branch
x86
FreeBSD

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

18 years ago
according to the FreeBSD-manpages the include needed for the ntohl funtions is
#include <sys/param.h>
according to the Linux-manpages the include needed is
#include <netinet/in.h>

the way the file currently is ... it doesn't compile .... missing defenition of
u_int32_t   which are used in <netinet/in.h>

I am currently testing a build on my system with only <sys/param.h> if that
turns out to build ... i would like to suggest to ifdef this case
(Reporter)

Comment 1

18 years ago
Created attachment 7125 [details] [diff] [review]
one-liner patch that fixes the build breakage on FreeBSD
(Reporter)

Comment 2

18 years ago
Oops ... path that this bug applies to is

mozilla/security/psm/lib/protocol
daeron@shadowmere.student.utwente.nl - thanks for this patch. Could you check it 
is still needed in the current Mozilla code, and that it still works? If that's 
the case, we'll confirm this bug and get it applied.

Gerv
(Reporter)

Comment 4

18 years ago
With the current Mozilla source tree the patch itself seems no longer needed
(and as far as i can see doesn't apply either) ... Mozilla compiles ... but
leaves a lot of warnings currently.

Like these:
gcc -o newproto.o -c -DOSTYPE=\"FreeBSD5\" -DOJI  -I../../../../dist/include
-I../../../../../include  -I/usr/local/include -I/usr/local/include 
-I/usr/X11R6/include   -fPIC -Wall -W -Wno-unused -Wshadow -Wpointer-arith
-Wcast-align -pedantic -Wno-long-long -pthread -O -include
../../../../config-defs.h -DMOZILLA_CLIENT
../../../../../security/psm/lib/protocol/newproto.c
../../../../../security/psm/lib/protocol/newproto.c: In function `decode_int':
../../../../../security/psm/lib/protocol/newproto.c:79: warning: implicit
declaration of function `ntohl'


and a whole shitload similair to these:

gcc -o templates.o -c -DOSTYPE=\"FreeBSD5\" -DOJI  -I../../../../dist/include
-I../../../../../include  -I/usr/local/include -I/usr/local/include 
-I/usr/X11R6/include   -fPIC -Wall -W -Wno-unused -Wshadow -Wpointer-arith
-Wcast-align -pedantic -Wno-long-long -pthread -O -include
../../../../config-defs.h -DMOZILLA_CLIENT
../../../../../security/psm/lib/protocol/templates.c
../../../../../security/psm/lib/protocol/templates.c:40: warning: missing
initializer
../../../../../security/psm/lib/protocol/templates.c:40: warning: (near
initialization for `SingleNumMessageTemplate[0].validator')
../../../../../security/psm/lib/protocol/templates.c:41: warning: missing
initializer

Confirming.

Gerv
Severity: normal → major
Status: UNCONFIRMED → NEW
Ever confirmed: true
daeron@shadowmere.student.utwente.nl - what are we doing about this bug?

Gerv
Closing due to lack of info from reporter :-)

Gerv
Status: NEW → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → INVALID

Comment 8

17 years ago
Verified per Gervaise's comments.
Status: RESOLVED → VERIFIED

Updated

13 years ago
Component: Security: UI → Security: UI
Product: PSM → Core

Updated

10 years ago
Version: psm1.01 → 1.0 Branch
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.