34035 - Build Breakage in security/psm/lib/protocol/newproto.c

Status: VERIFIED INVALID

(Core Graveyard :: Security: UI, defect, P3)

Description

[Pascal Hofstee]

according to the FreeBSD-manpages the include needed for the ntohl funtions is
#include <sys/param.h>
according to the Linux-manpages the include needed is
#include <netinet/in.h>

the way the file currently is ... it doesn't compile .... missing defenition of
u_int32_t   which are used in <netinet/in.h>

I am currently testing a build on my system with only <sys/param.h> if that
turns out to build ... i would like to suggest to ifdef this case

Comment 1

[Pascal Hofstee]

Attachment: one-liner patch that fixes the build breakage on FreeBSD

Comment 2

[Pascal Hofstee]

Oops ... path that this bug applies to is

mozilla/security/psm/lib/protocol

Comment 3

[Gervase Markham [:gerv]]

[e-mail] - thanks for this patch. Could you check it 
is still needed in the current Mozilla code, and that it still works? If that's 
the case, we'll confirm this bug and get it applied.

Gerv

Comment 4

[Pascal Hofstee]

With the current Mozilla source tree the patch itself seems no longer needed
(and as far as i can see doesn't apply either) ... Mozilla compiles ... but
leaves a lot of warnings currently.

Like these:
gcc -o newproto.o -c -DOSTYPE=\"FreeBSD5\" -DOJI  -I../../../../dist/include
-I../../../../../include  -I/usr/local/include -I/usr/local/include 
-I/usr/X11R6/include   -fPIC -Wall -W -Wno-unused -Wshadow -Wpointer-arith
-Wcast-align -pedantic -Wno-long-long -pthread -O -include
../../../../config-defs.h -DMOZILLA_CLIENT
../../../../../security/psm/lib/protocol/newproto.c
../../../../../security/psm/lib/protocol/newproto.c: In function `decode_int':
../../../../../security/psm/lib/protocol/newproto.c:79: warning: implicit
declaration of function `ntohl'


and a whole shitload similair to these:

gcc -o templates.o -c -DOSTYPE=\"FreeBSD5\" -DOJI  -I../../../../dist/include
-I../../../../../include  -I/usr/local/include -I/usr/local/include 
-I/usr/X11R6/include   -fPIC -Wall -W -Wno-unused -Wshadow -Wpointer-arith
-Wcast-align -pedantic -Wno-long-long -pthread -O -include
../../../../config-defs.h -DMOZILLA_CLIENT
../../../../../security/psm/lib/protocol/templates.c
../../../../../security/psm/lib/protocol/templates.c:40: warning: missing
initializer
../../../../../security/psm/lib/protocol/templates.c:40: warning: (near
initialization for `SingleNumMessageTemplate[0].validator')
../../../../../security/psm/lib/protocol/templates.c:41: warning: missing
initializer

Comment 5

[Gervase Markham [:gerv]]

Confirming.

Gerv

Comment 6

[Gervase Markham [:gerv]]

[e-mail] - what are we doing about this bug?

Gerv

Comment 7

[Gervase Markham [:gerv]]

Closing due to lack of info from reporter :-)

Gerv

Comment 8

[John Unruh]

Verified per Gervaise's comments.