340373 - Escape key should cancel "send in Unicode (UTF-8)?" dialog

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Patrick Benny]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; ja; rv:1.8.0.4) Gecko/20060508 Firefox/1.5.0.4
Build Identifier: Mozilla Thunderbird 1.5.0.4 (20060516)

When attempting to send an email containing characters not included in the selected charset, the "XXXXXXXXXXXXXX" dialog is displayed offering to send in UTF-8. This dialog has the 3 buttons "Send in UTF-8", "Cancel", and "Send anyway".

Hitting Escape within this dialog should activate the "Cancel" button, but currently it activates "Send anyway", which is probably not what the user wants to do since this replaces all unknown characters in the email by "?"'s.
Normally the user will either send by UTF-8, or cancel sending in order to go set the encoding to a more suitable one.

For clarity's sake, the dialog uses text resource NS_ERROR_MSG_MULTILINGUAL_SEND.

Reproducible: Always

Steps to Reproduce:
1. Create new message (File -> New -> Message)
2. Select Japanese encoding (View -> Encoding -> Japanese (ISO-2022-JP))
3. Fill-in a "To" email address and subject
4. Type/paste an accentuated alphabetical letter in the message body (e.g. à)
5. Hit the "Send" button, the "Send as UTF-8?" dialog will appear
6. Hit the Escape key, this activates "Send anyway"
Actual Results:  
"Send anyway"

Expected Results:  
"Cancel"

Comment 1

[Patrick Benny]

(In reply to comment #0)
> When attempting to send an email containing characters not included in the
> selected charset, the "XXXXXXXXXXXXXX" dialog is displayed offering to send in
> UTF-8.

Sorry, this should have said:
- the "XXXXXXXXXXXXXX" dialog 
+ the "Send in UTF-8?" dialog
(I was going to look for a correct name to refer to the dialog but forgot to replace that.)

Comment 2

[Mike Cowperthwaite]

This happens in 2a1-0604 and 3a1-0529, as well.

Patrick is completely right that Cancel should be the default action of the Escape key.

Comment 3

[Scott MacGregor]

I agree. this should be a pretty easy beginner bug for someone looking to get started.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Attachment: use button 1 for cancel instead of button 2

commonDialog.js sets the cancel button to the button at index 1 in the button flags, so POS_1 should be used for the cancel button. The only implementation that I tested was the c++ one, which seemingly is the only one that affects my trunk Tbird build. I patched the other ones for good measure... I have no idea if they are used.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Checked in on the trunk. Should this go on the 1.8 branch too?

Comment 6

[Simon Montagu :smontagu]

*** Bug 363738 has been marked as a duplicate of this bug. ***

Comment 7

[Scott MacGregor]

not going to block for this, but I'm about to  approve it anyway. 

Comment 8

[Scott MacGregor]

Gavid, do you mind landing this on the branch too?

thanks!

Comment 9

[:Gavin Sharp [email: [e-mail]]]

Oops, sorry that I missed the approval, Scott! I'll land this on the branch in a few minutes.

Comment 10

[:Gavin Sharp [email: [e-mail]]]

mozilla/mailnews/compose/resources/content/MsgComposeCommands.js 1.369.2.17
mozilla/mailnews/compose/src/nsMsgCompose.cpp 	1.460.2.30
mozilla/mailnews/compose/src/nsMsgPrompts.cpp 	1.28.8.1
mozilla/mailnews/compose/src/nsMsgSend.cpp 	1.374.2.8
mozilla/mail/components/compose/content/MsgComposeCommands.js 	1.72.2.30

Comment 11

[Carsten Book [:Tomcat]]

verified fixed 1.8.1.3 using Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.1.3) Gecko/20070326 Thunderbird/2.0.0.0 Mnenhy/0.7.5.0 ID:2007032620 Escape cancel the UTF-8 dialog