Last Comment Bug 340426 - Add a navbar at the top of each pages + have a better title
: Add a navbar at the top of each pages + have a better title
Status: RESOLVED FIXED
:
Product: Bugzilla
Classification: Server Software
Component: User Interface (show other bugs)
: 2.23
: All All
: -- enhancement (vote)
: Bugzilla 3.0
Assigned To: Frédéric Buclin
: default-qa
Mentors:
http://landfill.bugzilla.org/notifica...
Depends on:
Blocks: 341273
  Show dependency treegraph
 
Reported: 2006-06-05 11:16 PDT by Frédéric Buclin
Modified: 2007-02-15 07:55 PST (History)
9 users (show)
justdave: approval+
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch, v1 (10.56 KB, patch)
2006-06-05 11:17 PDT, Frédéric Buclin
glob: review-
Details | Diff | Review
firefox - patched (77.14 KB, image/gif)
2006-06-05 20:45 PDT, Byron Jones ‹:glob›
no flags Details
ie - unpatched (71.37 KB, image/gif)
2006-06-05 20:46 PDT, Byron Jones ‹:glob›
no flags Details
ie - patched (76.04 KB, image/gif)
2006-06-05 20:46 PDT, Byron Jones ‹:glob›
no flags Details
globals.css fixes (2.90 KB, patch)
2006-06-08 07:50 PDT, Byron Jones ‹:glob›
no flags Details | Diff | Review
patch, v2 (11.98 KB, patch)
2006-06-08 11:58 PDT, Frédéric Buclin
glob: review+
Details | Diff | Review

Description Frédéric Buclin 2006-06-05 11:16:48 PDT
It's a pain to scroll down again and again to reach the navbar. They should be displayed at the top too (not admin pages nor saved searches, only common links).

Moreover, I think the title could have some cleanup, see the link in the URL field.

I know some people like it, I also know some people don't. But if we do nothing, we will never improve it. And waiting for AJAX and gandalf's new UI is too long IMO, especially because we will have the same kind of discussion as we may have here.
Comment 1 Frédéric Buclin 2006-06-05 11:17:32 PDT
Created attachment 224451 [details] [diff] [review]
patch, v1

Here is an attempt.
Comment 2 Byron Jones ‹:glob› 2006-06-05 20:45:55 PDT
Created attachment 224514 [details]
firefox - patched
Comment 3 Byron Jones ‹:glob› 2006-06-05 20:46:20 PDT
Created attachment 224516 [details]
ie - unpatched
Comment 4 Byron Jones ‹:glob› 2006-06-05 20:46:43 PDT
Created attachment 224517 [details]
ie - patched
Comment 5 Byron Jones ‹:glob› 2006-06-05 20:56:33 PDT
Comment on attachment 224451 [details] [diff] [review]
patch, v1

i've attached what the patch looks like in IE.

i agree with the intent of this patch, however there's some issues with how IE displays the new style.

the text size of the header and footer is large, which results in bad layout.  while the footer text size problem isn't new, may as well tweak it now.

padding is missing from the header div in IE.
Comment 6 Frédéric Buclin 2006-06-05 23:44:46 PDT
Byron, I'm not a big CSS expert, and I can hardly test on IE (I'm using Linux). Could you help me fixing the issues you reported in comment 5?
Comment 7 Byron Jones ‹:glob› 2006-06-08 07:50:07 PDT
Created attachment 224863 [details] [diff] [review]
globals.css fixes

here's a first try at getting it working on FF and IE.
patch covers global.css changes only.
Comment 8 Frédéric Buclin 2006-06-08 11:58:56 PDT
Created attachment 224892 [details] [diff] [review]
patch, v2

Mixing my patch with glob's one + fixes we made together.
Comment 9 Byron Jones ‹:glob› 2006-06-09 07:13:54 PDT
Comment on attachment 224892 [details] [diff] [review]
patch, v2

r=glob
Comment 10 Vlad Dascalu 2006-06-09 09:05:29 PDT
Comment on attachment 224892 [details] [diff] [review]
patch, v2

So this no longer displays the Bugzilla version? :-(
Comment 11 Frédéric Buclin 2006-06-10 01:31:32 PDT
(In reply to comment #10)
> So this no longer displays the Bugzilla version? :-(

Right. This is useless and doesn't suit well in the UI. Even b.m.o doesn't display it anymore.
Comment 12 Vlad Dascalu 2006-06-10 03:48:43 PDT
b.m.o. does display it, even if it's relatively small (and right centered).

> This is useless

It is of critical importance in my opinion, since I can google "Bugzilla 2.18", "Bugzilla 2.20" and see deployment statistics for free.

Personally I strongly preffer to keep this information.

Also, probably the "Actions:" label should be duplicated at the top of the "toolbar", to keep consistency with the footer.
Comment 13 Frédéric Buclin 2006-06-10 03:56:26 PDT
(In reply to comment #12)
> It is of critical importance in my opinion, since I can google "Bugzilla 2.18",
> "Bugzilla 2.20" and see deployment statistics for free.

I don't see how stats could be of critical importance. Moreover, there is config.cgi for that.


> Also, probably the "Actions:" label should be duplicated at the top of the
> "toolbar", to keep consistency with the footer.

"Actions:" is useless; really. And we already are consistent with links displayed.
Comment 14 Vlad Dascalu 2006-06-10 07:34:50 PDT
> I don't see how stats could be of critical importance. 

I guess it depends on the personal perspective from which you look at it. We are developers; probably a marketer (if Bugzilla had one) that gathers his data would say otherwise.

> Moreover, there is config.cgi for that.

It's not usually spidered by search engines.
Comment 15 Byron Jones ‹:glob› 2006-06-11 18:17:10 PDT
it's trivial to write a script that looks for bugzilla installs and determines the installed version.

polluting the ui isn't the correct way to resolve that problem.
Comment 16 Dave Miller [:justdave] (justdave@bugzilla.org) 2006-06-12 10:06:37 PDT
(In reply to comment #11)
> (In reply to comment #10)
> > So this no longer displays the Bugzilla version? :-(
> 
> Right. This is useless and doesn't suit well in the UI.

As an end user who is mildly technically savvy, I like knowing what version a site is using as I use it without having to play tricks to find out.  Having the version displayed also allows end users to pester the admin when an upgrade is available in case the admin never logs in to get their update notification ;)

> Even b.m.o doesn't display it anymore.

We sure as hell do. :)  it's on the right-hand size of the blue bar, along the bottom edge, in white text.
Comment 17 Frédéric Buclin 2006-06-12 10:17:14 PDT
How many softwares display their version on every page?
Comment 18 Dave Miller [:justdave] (justdave@bugzilla.org) 2006-06-12 10:27:21 PDT
We need the rest of this too much to squabble about little pieces right now.
Comment 19 Frédéric Buclin 2006-06-12 10:36:16 PDT
Checking in skins/standard/global.css;
/cvsroot/mozilla/webtools/bugzilla/skins/standard/global.css,v  <--  global.css
new revision: 1.21; previous revision: 1.20
done
Checking in template/en/default/filterexceptions.pl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/filterexceptions.pl,v  <--  filterexceptions.pl
new revision: 1.69; previous revision: 1.68
done
Checking in template/en/default/bug/show.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/show.html.tmpl,v  <--  show.html.tmpl
new revision: 1.12; previous revision: 1.11
done
Checking in template/en/default/global/banner.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/banner.html.tmpl,v  <--  banner.html.tmpl
new revision: 1.9; previous revision: 1.8
done
RCS file: /cvsroot/mozilla/webtools/bugzilla/template/en/default/global/common-links.html.tmpl,v
done
Checking in template/en/default/global/common-links.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/common-links.html.tmpl,v  <--  common-links.html.tmpl
initial revision: 1.1
done
Checking in template/en/default/global/header.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/header.html.tmpl,v  <--  header.html.tmpl
new revision: 1.41; previous revision: 1.40
done
Checking in template/en/default/global/useful-links.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/useful-links.html.tmpl,v  <--  useful-links.html.tmpl
new revision: 1.45; previous revision: 1.44
done
Comment 20 Max Kanat-Alexander 2007-02-14 16:11:02 PST
Added to the release notes on bug 255155.
Comment 21 Max Kanat-Alexander 2007-02-15 07:55:00 PST
The correct bug number for those release notes is actually bug 349423.

Note You need to log in before you can comment on or make changes to this bug.