Closed
Bug 340434
Opened 18 years ago
Closed 18 years ago
"Grouped By Sort" (for status) has no Group for "Unread" messages - Both Unread AND read are shown as "Read"
Categories
(Thunderbird :: Mail Window Front End, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird2.0
People
(Reporter: Thunderbird_Mail_DE, Assigned: mscott)
Details
(Keywords: fixed1.8.1)
Attachments
(2 files)
10.60 KB,
image/png
|
Details | |
4.82 KB,
patch
|
Bienvenu
:
superreview+
|
Details | Diff | Splinter Review |
Thunderbird 2.0a1 Mozilla_1.8_Branch build 2006-06-05 Select group by "Status", then group by sort (Cmd-Key "G"). In the thread pane you can see the groups for "Replied", "Read" and _AGAIN_ "Read" instead of "Unread". BTW: In messenger.properties I can't find a text string for the necessary group "Unread".
Reporter | ||
Comment 1•18 years ago
|
||
Updated•18 years ago
|
Severity: normal → minor
Assignee | ||
Comment 2•18 years ago
|
||
I see that to. Could that have been broken since 1.0? Ouch! should be an easy string fix.
Target Milestone: --- → Thunderbird2.0
Assignee | ||
Comment 3•18 years ago
|
||
m_flags for the dummy row for messages with no status in nsMsgGroupView has the read flag set on it, where it should have a value of 0. Hence, we end up fetching the wrong string.
Assignee | ||
Comment 4•18 years ago
|
||
When we create a dummy row in our view, we set the read flag on the row: http://lxr.mozilla.org/mozilla/source/mailnews/base/src/nsMsgGroupView.cpp#301 That keeps us from properly setting the right grouped by status text for messages with no status.
Comment 5•18 years ago
|
||
we do that so next unread won't land on the group row. So we might need to fix the next unread problem in a different way, or fix this some other way.
Assignee | ||
Comment 6•18 years ago
|
||
1) Remove FindNextUnread which no one is calling anymore 2) Make FindPrevUnread and the inline code for FindNextUnread skip over dummy rows. 3) Stop setting the unread flag on a group dummy row in nsMsgGroupView.
Attachment #231806 -
Flags: superreview?(bienvenu)
Updated•18 years ago
|
Attachment #231806 -
Flags: superreview?(bienvenu) → superreview+
Assignee | ||
Updated•18 years ago
|
Comment 7•18 years ago
|
||
In a similar vein to this bug: Messages with status "Replied and Forwarded" are always shown only as "Replied" in the Status column, but they are broken out into a different Group from replied-only messages. Both groups are called "Replied." In the column, maybe the text "Repl+Fwd" would be nice (to help keep it narrow), but the group probably should be "Replied and Forwarded." Scott, do you want a separate bug for this?
Comment 8•18 years ago
|
||
Oh, and: "No Status" seems counterintuitive for messages that are Unread but not New. From a user's standpoint, "Unread" seems an actual status-of- interest, "No status" applies more to "Read" messages.
Reporter | ||
Comment 9•18 years ago
|
||
And one more thing: we should reorder the different status' - new - no status (better: "unread") - read - replied - forwarded - replied and forwarded This would match the way users are working.
Reporter | ||
Comment 10•18 years ago
|
||
Any comment?
Reporter | ||
Comment 11•17 years ago
|
||
The main problem seems to be fixed in Thunderbird 2.
You need to log in
before you can comment on or make changes to this bug.
Description
•