The default bug view has changed. See this FAQ.

SuggestionURL should be SuggestionUrl for consistency with opensearch Url tag

RESOLVED FIXED in Firefox 2 beta1

Status

()

Firefox
Search
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: Nickolay_Ponomarev, Assigned: Nickolay_Ponomarev)

Tracking

({fixed1.8.1})

2.0 Branch
Firefox 2 beta1
fixed1.8.1
Points:
---
Bug Flags:
blocking-firefox2 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

11 years ago
The non-standard SuggestionURL tag in search plugin's description has inconsistent capitalization compared to OpenSearch-defined Url tag.

While consistently using "URL" would be a better choice, the OpenSearch spec is not under our control, so we should use SuggestionUrl for consistency.
(Assignee)

Comment 1

11 years ago
Created attachment 224474 [details] [diff] [review]
patch
Assignee: nobody → asqueella
Status: NEW → ASSIGNED
Attachment #224474 - Flags: review?(gavin.sharp)
If we make such a change, I think we should make it before b1.
Flags: blocking-firefox2?
Target Milestone: --- → Firefox 2 beta1
Version: Trunk → 2.0 Branch
Agreed; otherwise we risk impacting a lot of people.
Comment on attachment 224474 [details] [diff] [review]
patch

mconnor should decide on this.
Attachment #224474 - Flags: review?(gavin.sharp) → review?(mconnor)
Comment on attachment 224474 [details] [diff] [review]
patch

Ok, kinda silly, but whatever
Attachment #224474 - Flags: review?(mconnor)
Attachment #224474 - Flags: review+
Attachment #224474 - Flags: approval-branch-1.8.1+

Updated

11 years ago
Assignee: asqueella → nobody
Status: ASSIGNED → NEW
Flags: blocking-firefox2? → blocking-firefox2+

Updated

11 years ago
Assignee: nobody → asqueella
(Assignee)

Comment 6

11 years ago
Gavin, would you check it in, please?
Whiteboard: [checkin needed]
Checked in branch and trunk. Nickolay, can you post to the l10n newsgroup announcing this change, and update any devmo docs accordingly?
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Whiteboard: [checkin needed]
(Assignee)

Comment 8

11 years ago
Done: http://groups.google.com/group/mozilla.dev.l10n/browse_frm/thread/f38a89b0aed0fedb/1772a9f110e48d6a#1772a9f110e48d6a
http://developer.mozilla.org/en/docs/index.php?title=Creating_MozSearch_plugins&curid=8226&diff=33631&oldid=33247&rcid=34194
(In reply to comment #8)
> Done:

Awesome, thanks!
You need to log in before you can comment on or make changes to this bug.