Closed Bug 340444 Opened 18 years ago Closed 18 years ago

SuggestionURL should be SuggestionUrl for consistency with opensearch Url tag

Categories

(Firefox :: Search, defect)

Product:
Firefox
Component:
Search
Version:
2.0 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 2 beta1

People

(Reporter: asqueella, Assigned: asqueella)

Details

(Keywords: fixed1.8.1)

Attachments

(1 file)

patch
4.77 KB, patch
mconnor
: review+
mconnor
: approval-branch-1.8.1+
Details | Diff | Splinter Review 
The non-standard SuggestionURL tag in search plugin's description has inconsistent capitalization compared to OpenSearch-defined Url tag.

While consistently using "URL" would be a better choice, the OpenSearch spec is not under our control, so we should use SuggestionUrl for consistency.
Attached patch patch — — Splinter Review 
Assignee: nobody → asqueella
Status: NEW → ASSIGNED

        Attachment #224474 -
        Flags: review?(gavin.sharp)

    
    

    
  
If we make such a change, I think we should make it before b1.
Flags: blocking-firefox2?
Target Milestone: --- → Firefox 2 beta1
Version: Trunk → 2.0 Branch

    
    

    
  
Agreed; otherwise we risk impacting a lot of people.

    
    

    
  
Comment on attachment 224474 [details] [diff] [review]
patch

mconnor should decide on this.

        Attachment #224474 -
        Flags: review?(gavin.sharp) → review?(mconnor)

    
    

    
  
Comment on attachment 224474 [details] [diff] [review]
patch

Ok, kinda silly, but whatever

        Attachment #224474 -
        Flags: review?(mconnor)

        Attachment #224474 -
        Flags: review+

        Attachment #224474 -
        Flags: approval-branch-1.8.1+
Assignee: asqueella → nobody
Status: ASSIGNED → NEW
Flags: blocking-firefox2? → blocking-firefox2+
Assignee: nobody → asqueella

    
    

    
  
Gavin, would you check it in, please?
Whiteboard: [checkin needed]

    
    

    
  
Checked in branch and trunk. Nickolay, can you post to the l10n newsgroup announcing this change, and update any devmo docs accordingly?
Status: NEW → RESOLVED
Closed: 18 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Whiteboard: [checkin needed]

    
    

    
  
(In reply to comment #8)
> Done:

Awesome, thanks!

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: