Last Comment Bug 340444 - SuggestionURL should be SuggestionUrl for consistency with opensearch Url tag
: SuggestionURL should be SuggestionUrl for consistency with opensearch Url tag
Status: RESOLVED FIXED
: fixed1.8.1
Product: Firefox
Classification: Client Software
Component: Search (show other bugs)
: 2.0 Branch
: All All
: -- normal (vote)
: Firefox 2 beta1
Assigned To: Nickolay_Ponomarev
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-06-05 14:00 PDT by Nickolay_Ponomarev
Modified: 2006-06-08 14:49 PDT (History)
4 users (show)
mconnor: blocking‑firefox2+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (4.77 KB, patch)
2006-06-05 14:01 PDT, Nickolay_Ponomarev
mconnor: review+
mconnor: approval‑branch‑1.8.1+
Details | Diff | Splinter Review

Description Nickolay_Ponomarev 2006-06-05 14:00:15 PDT
The non-standard SuggestionURL tag in search plugin's description has inconsistent capitalization compared to OpenSearch-defined Url tag.

While consistently using "URL" would be a better choice, the OpenSearch spec is not under our control, so we should use SuggestionUrl for consistency.
Comment 1 Nickolay_Ponomarev 2006-06-05 14:01:45 PDT
Created attachment 224474 [details] [diff] [review]
patch
Comment 2 :Gavin Sharp [email: gavin@gavinsharp.com] 2006-06-05 14:04:12 PDT
If we make such a change, I think we should make it before b1.
Comment 3 Eric Shepherd [:sheppy] 2006-06-05 14:06:25 PDT
Agreed; otherwise we risk impacting a lot of people.
Comment 4 :Gavin Sharp [email: gavin@gavinsharp.com] 2006-06-05 18:38:42 PDT
Comment on attachment 224474 [details] [diff] [review]
patch

mconnor should decide on this.
Comment 5 Mike Connor [:mconnor] 2006-06-06 18:28:52 PDT
Comment on attachment 224474 [details] [diff] [review]
patch

Ok, kinda silly, but whatever
Comment 6 Nickolay_Ponomarev 2006-06-07 03:32:21 PDT
Gavin, would you check it in, please?
Comment 7 :Gavin Sharp [email: gavin@gavinsharp.com] 2006-06-08 11:13:11 PDT
Checked in branch and trunk. Nickolay, can you post to the l10n newsgroup announcing this change, and update any devmo docs accordingly?
Comment 9 :Gavin Sharp [email: gavin@gavinsharp.com] 2006-06-08 14:49:30 PDT
(In reply to comment #8)
> Done:

Awesome, thanks!

Note You need to log in before you can comment on or make changes to this bug.