Closed Bug 34048 Opened 24 years ago Closed 24 years ago

NSPR library loading fix: specify fragment names of the DLLs

Categories

(NSPR :: NSPR, defect, P3)

PowerPC
Mac System 8.5
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: wtc, Assigned: wtc)

Details

This bug is reported by sfraser@netscape.com (Simon Fraser):

This change allows mac developers to see fragment names
of the DLLs
that they are debugging. We need it!

Index: macdll.c

===================================================================
RCS file:
/cvsroot/mozilla/nsprpub/pr/src/md/mac/macdll.c,v
retrieving revision 3.5
diff -w -c -1 -r3.5 macdll.c
*** macdll.c    1999/12/02 22:25:12     3.5
--- macdll.c    2000/03/31 02:32:07
***************
*** 532,533 ****
--- 532,542 ----
        
+       if (fragNameBlock)
+       {
+         UInt32 nameLen = strlen(fragNameBlock);
+         if (nameLen > 63)
+           nameLen = 63;
+         BlockMoveData(fragNameBlock, &fragName[1],
nameLen);
+         fragName[0] = nameLen;
+       }
+       
        err = GetDiskFragment(fileSpec, fragOffset,
fragLength, fragName,
fragName is a Str255. Does that mean it can
be up to 255 character long? Why do you only
copy 63 characters into it?

Please indicate the severity of this bug.
Status: NEW → ASSIGNED
Because GetDiskFragment takes a ConstStr63Param (max 63 bytes long). Fragment 
names can never be longer than 63 chars, I think.
The patch is checked in on the main trunk.
/cvsroot/mozilla/nsprpub/pr/src/md/mac/macdll.c, revision 3.6

Checked in on the NSPRPUB_RELEASE_4_0_BRANCH.
/cvsroot/mozilla/nsprpub/pr/src/md/mac/macdll.c, revision 3.5.8.1

Leaf, this fix needs to be merged into the cvs tag
that the mozilla client is pulling.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
The fix is checked in on the NSPRPUB_CLIENT_BRANCH.
/cvsroot/mozilla/nsprpub/pr/src/md/mac/macdll.c, revision 3.5.22.1
Target Milestone: --- → 4.0.1
Target Milestone: 4.0.1 → 4.0.2
You need to log in before you can comment on or make changes to this bug.