340540 - Manage Search Engines: Engines are moved out of view

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[Malte Kraus]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1a3) Gecko/20060606 BonEcho/2.0a3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1a3) Gecko/20060606 BonEcho/2.0a3

If the top-most visible engine is moved up, it becomes invisible. The same for the other direction.

Reproducible: Always

Steps to Reproduce:
1. Click on the little arrow in the search box
2. Click 'Manage Search Engines'
3. Make sure you have over 10 Search Engines installed so that there is a Scrollbar in the window that appears
4. Select the top-most Engine and click at least 10 times on the 'Move Down' Button
Actual Results:  
the engine is moved somewhere you can't see it.

Expected Results:  
The scrollbar should be moved so that the engine keeps always visible.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

Indeed, thanks for the report!

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Fixed for Firefox 2 beta 1.

mozilla/browser/components/search/content/engineManager.js 	1.1.2.7
mozilla/browser/components/search/content/engineManager.js 	1.5

Comment 3

[Ria Klaassen (not reading all bugmail)]

I see an error that seems to belong to this bug. Don't know if I need to file a whole new bug for it. Nothing seems to go wrong at first sight.

- In the Search Engine Manager click Move up or Move down
- An error will appear:

Error: index is not defined
Source File: chrome://browser/content/search/engineManager.js
Line: 88

Comment 4

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #3)
> I see an error that seems to belong to this bug.

Yes, you're right, I just noticed this myself. I made a stupid mistake when I landed the patch, I'll correct it now.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Attachment: duh-fix

I just landed this on the trunk and branch, it should fix any issues.