Closed Bug 340555 Opened 18 years ago Closed 18 years ago

Toolkit feed parser needs nicer API

Categories

(Firefox Graveyard :: RSS Discovery and Preview, defect)

Product:
Firefox Graveyard
Component:
RSS Discovery and Preview
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 2

People

(Reporter: sayrer, Assigned: sayrer)

References

Details

(Keywords: fixed1.8.1)

Attachments

(2 files, 1 obsolete file)

new patch, no bitrot
86.71 KB, patch
vlad
: review+
mtschrep
: approval1.8.1+
Details | Diff | Splinter Review
extension authors shouldn't have to use XHR to parse a feed from a URI
1.91 KB, patch
Details | Diff | Splinter Review
Status: NEW → ASSIGNED
Whiteboard: [swag: 3d]
Target Milestone: --- → Firefox 2 beta1
Flags: blocking-firefox2?
Flags: blocking-firefox2? → blocking-firefox2+
Robert - can you give us a better sense of what you'd like to do here?  Wondering if this is critical for b1 or not.

One part of it is critical for b1 if we want to get HTML turned on in the feed preview: return nsITextConstructs instead of strings for title/summary/content. We didn't bother before because it was executing w/ chrome privs.

I want to add some convenience methods for dates, categories, etc. That's not critical for b1, though.
Target Milestone: Firefox 2 beta1 → Firefox 2 beta2
Depends on: 344389
Depends on: 344991
Whiteboard: [swag: 3d] → [ETA 7/28]
Depends on: 340554, 345065
Target Milestone: Firefox 2 beta2 → Firefox 2

    
    

    
  
Comment on attachment 231487 [details] [diff] [review]
authors, dates, generator, rights

Vlad, we need to take this patch to land bug 340554 with no issues. It doesn't fix this bug completely, but it is a start.

        Attachment #231487 -
        Flags: review?(vladimir)

    
    

    
  
Comment on attachment 231487 [details] [diff] [review]
authors, dates, generator, rights

r=me; please make sure to generate new uuid's for all the old interfaces that you changed

        Attachment #231487 -
        Flags: review?(vladimir) → review+

    
  
Whiteboard: [ETA 7/28]

    
    

    
  
Checking in toolkit/components/feeds/public/Makefile.in;
/cvsroot/mozilla/toolkit/components/feeds/public/Makefile.in,v  <--  Makefile.in
new revision: 1.3; previous revision: 1.2
done
Checking in toolkit/components/feeds/public/nsIFeed.idl;
/cvsroot/mozilla/toolkit/components/feeds/public/nsIFeed.idl,v  <--  nsIFeed.idl
new revision: 1.3; previous revision: 1.2
done
Checking in toolkit/components/feeds/public/nsIFeedContainer.idl;
/cvsroot/mozilla/toolkit/components/feeds/public/nsIFeedContainer.idl,v  <--  nsIFeedContainer.idl
new revision: 1.6; previous revision: 1.5
done
RCS file: /cvsroot/mozilla/toolkit/components/feeds/public/nsIFeedElementBase.idl,v
done
Checking in toolkit/components/feeds/public/nsIFeedElementBase.idl;
/cvsroot/mozilla/toolkit/components/feeds/public/nsIFeedElementBase.idl,v  <--  nsIFeedElementBase.idl
initial revision: 1.1
done
Checking in toolkit/components/feeds/public/nsIFeedEntry.idl;
/cvsroot/mozilla/toolkit/components/feeds/public/nsIFeedEntry.idl,v  <--  nsIFeedEntry.idl
new revision: 1.3; previous revision: 1.2
done
RCS file: /cvsroot/mozilla/toolkit/components/feeds/public/nsIFeedGenerator.idl,v
done
Checking in toolkit/components/feeds/public/nsIFeedGenerator.idl;
/cvsroot/mozilla/toolkit/components/feeds/public/nsIFeedGenerator.idl,v  <--  nsIFeedGenerator.idl
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/components/feeds/public/nsIFeedPerson.idl,v
done
Checking in toolkit/components/feeds/public/nsIFeedPerson.idl;
/cvsroot/mozilla/toolkit/components/feeds/public/nsIFeedPerson.idl,v  <--  nsIFeedPerson.idl
initial revision: 1.1
done
Checking in toolkit/components/feeds/src/FeedProcessor.js;
/cvsroot/mozilla/toolkit/components/feeds/src/FeedProcessor.js,v  <--  FeedProcessor.js
new revision: 1.11; previous revision: 1.10
done
RCS file: /cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_author.xml,v
done
Checking in toolkit/components/feeds/test/xml/rfc4287/entry_author.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_author.xml,v  <--  entry_author.xml
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_contributor.xml,v
done
Checking in toolkit/components/feeds/test/xml/rfc4287/entry_contributor.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_contributor.xml,v  <--  entry_contributor.xml
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_published.xml,v
done
Checking in toolkit/components/feeds/test/xml/rfc4287/entry_published.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_published.xml,v  <--  entry_published.xml
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_rights_normalized.xml,v
done
Checking in toolkit/components/feeds/test/xml/rfc4287/entry_rights_normalized.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_rights_normalized.xml,v  <--  entry_rights_normalized.xml
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_summary_html.xml,v
done
Checking in toolkit/components/feeds/test/xml/rfc4287/entry_summary_html.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_summary_html.xml,v  <--  entry_summary_html.xml
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_summary_html.xml~,v
done
Checking in toolkit/components/feeds/test/xml/rfc4287/entry_summary_html.xml~;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_summary_html.xml~,v  <--  entry_summary_html.xml~
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_updated.xml,v
done
Checking in toolkit/components/feeds/test/xml/rfc4287/entry_updated.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_updated.xml,v  <--  entry_updated.xml
initial revision: 1.1
done
Checking in toolkit/components/feeds/test/xml/rfc4287/feed_author.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/feed_author.xml,v  <--  feed_author.xml
new revision: 1.2; previous revision: 1.1
done
Checking in toolkit/components/feeds/test/xml/rfc4287/feed_author2.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/feed_author2.xml,v  <--  feed_author2.xml
new revision: 1.2; previous revision: 1.1
done
Checking in toolkit/components/feeds/test/xml/rfc4287/feed_author_email.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/feed_author_email.xml,v  <--  feed_author_email.xml
new revision: 1.2; previous revision: 1.1
done
Checking in toolkit/components/feeds/test/xml/rfc4287/feed_author_email_2.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/feed_author_email_2.xml,v  <--  feed_author_email_2.xml
new revision: 1.2; previous revision: 1.1
done
Checking in toolkit/components/feeds/test/xml/rfc4287/feed_author_name.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/feed_author_name.xml,v  <--  feed_author_name.xml
new revision: 1.2; previous revision: 1.1
done
Checking in toolkit/components/feeds/test/xml/rfc4287/feed_author_surrounded.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/feed_author_surrounded.xml,v  <--  feed_author_surrounded.xml
new revision: 1.2; previous revision: 1.1
done
Checking in toolkit/components/feeds/test/xml/rfc4287/feed_author_uri.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/feed_author_uri.xml,v  <--  feed_author_uri.xml
new revision: 1.2; previous revision: 1.1
done
Checking in toolkit/components/feeds/test/xml/rfc4287/feed_contributor.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/feed_contributor.xml,v  <--  feed_contributor.xml
new revision: 1.2; previous revision: 1.1
done
Checking in toolkit/components/feeds/test/xml/rfc4287/feed_generator.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/feed_generator.xml,v  <--  feed_generator.xml
new revision: 1.2; previous revision: 1.1
done
Checking in toolkit/components/feeds/test/xml/rfc4287/feed_generator_uri.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/feed_generator_uri.xml,v  <--  feed_generator_uri.xml
new revision: 1.2; previous revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/feed_generator_uri_xmlbase.xml,v
done
Checking in toolkit/components/feeds/test/xml/rfc4287/feed_generator_uri_xmlbase.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/feed_generator_uri_xmlbase.xml,v  <--  feed_generator_uri_xmlbase.xml
initial revision: 1.1
done
Checking in toolkit/components/feeds/test/xml/rfc4287/feed_generator_version.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/feed_generator_version.xml,v  <--  feed_generator_version.xml
new revision: 1.2; previous revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/feed_rights_normalized.xml,v
done
Checking in toolkit/components/feeds/test/xml/rfc4287/feed_rights_normalized.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/feed_rights_normalized.xml,v  <--  feed_rights_normalized.xml
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/feed_updated_normalized.xml,v
done
Checking in toolkit/components/feeds/test/xml/rfc4287/feed_updated_normalized.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/feed_updated_normalized.xml,v  <--  feed_updated_normalized.xml
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/components/feeds/test/xml/rss1/feed_generator.xml,v
done
Checking in toolkit/components/feeds/test/xml/rss1/feed_generator.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rss1/feed_generator.xml,v  <--  feed_generator.xml
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/components/feeds/test/xml/rss1/feed_updated.xml,v
done
Checking in toolkit/components/feeds/test/xml/rss1/feed_updated.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rss1/feed_updated.xml,v  <--  feed_updated.xml
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/components/feeds/test/xml/rss1/feed_updated_dctermsmodified.xml,v
done
Checking in toolkit/components/feeds/test/xml/rss1/feed_updated_dctermsmodified.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rss1/feed_updated_dctermsmodified.xml,v  <--  feed_updated_dctermsmodified.xml
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/components/feeds/test/xml/rss1/item_dc_creator.xml,v
done
Checking in toolkit/components/feeds/test/xml/rss1/item_dc_creator.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rss1/item_dc_creator.xml,v  <--  item_dc_creator.xml
initial revision: 1.1
done
Checking in toolkit/components/feeds/test/xml/rss1/item_dc_description.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rss1/item_dc_description.xml,v  <--  item_dc_description.xml
new revision: 1.2; previous revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/components/feeds/test/xml/rss1/item_updated_dcterms.xml,v
done
Checking in toolkit/components/feeds/test/xml/rss1/item_updated_dcterms.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rss1/item_updated_dcterms.xml,v  <--  item_updated_dcterms.xml
initial revision: 1.1
done
Checking in toolkit/components/feeds/test/xml/rss2/feed_dc_contributor.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rss2/feed_dc_contributor.xml,v  <--  feed_dc_contributor.xml
new revision: 1.2; previous revision: 1.1
done
Checking in toolkit/components/feeds/test/xml/rss2/feed_dc_creator.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rss2/feed_dc_creator.xml,v  <--  feed_dc_creator.xml
new revision: 1.2; previous revision: 1.1
done
Checking in toolkit/components/feeds/test/xml/rss2/feed_generator.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rss2/feed_generator.xml,v  <--  feed_generator.xml
new revision: 1.2; previous revision: 1.1
done
Checking in toolkit/components/feeds/test/xml/rss2/feed_managingEditor.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rss2/feed_managingEditor.xml,v  <--  feed_managingEditor.xml
new revision: 1.2; previous revision: 1.1
done
Checking in toolkit/components/feeds/test/xml/rss2/feed_managingEditor_extra_att.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rss2/feed_managingEditor_extra_att.xml,v  <--  feed_managingEditor_extra_att.xml
new revision: 1.2; previous revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/components/feeds/test/xml/rss2/feed_updated.xml,v
done
Checking in toolkit/components/feeds/test/xml/rss2/feed_updated.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rss2/feed_updated.xml,v  <--  feed_updated.xml
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/components/feeds/test/xml/rss2/feed_updated_dcdate.xml,v
done
Checking in toolkit/components/feeds/test/xml/rss2/feed_updated_dcdate.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rss2/feed_updated_dcdate.xml,v  <--  feed_updated_dcdate.xml
initial revision: 1.1
done
Checking in toolkit/components/feeds/test/xml/rss2/item_author.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rss2/item_author.xml,v  <--  item_author.xml
new revision: 1.2; previous revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/components/feeds/test/xml/rss2/item_published.xml,v
done
Checking in toolkit/components/feeds/test/xml/rss2/item_published.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rss2/item_published.xml,v  <--  item_published.xml
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/components/feeds/test/xml/rss2/item_updated_dcdate.xml,v
done
Checking in toolkit/components/feeds/test/xml/rss2/item_updated_dcdate.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rss2/item_updated_dcdate.xml,v  <--  item_updated_dcdate.xml
initial revision: 1.1
done

    
  

        Attachment #231487 -
        Flags: approval1.8.1?

    
    

    
  
drivers, per beltzner's comment in bug 340554, we're taking the first part of this to make sure everything is cleanly landed. This patch really isn't that scary, it's mostly idl and tests.

    
    

    
  
Comment on attachment 231487 [details] [diff] [review]
authors, dates, generator, rights

a=beltzner on behalf of drivers for the mozilla_1_8_branch

        Attachment #231487 -
        Flags: approval1.8.1? → approval1.8.1+

    
    

    
  
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060816 Minefield/3.0a1 ID:2006081600 [cairo]

feed preview is broken/empty.
regression 081504-081600.
this checkin or Bug#348586 cause this ?

    
    

    
  
(In reply to comment #9)
> Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060816
> Minefield/3.0a1 ID:2006081600 [cairo]
> 
> feed preview is broken/empty.
> regression 081504-081600.
> this checkin or Bug#348586 cause this ?

It's not 348586. I see the problem, and I am *positive* I ran the tests before I checked in, so I'm looking to see if something else bit me (hmm, bug 336379 changed the scoping of catch blocks).

    
    

    
  
(In reply to comment #10)
> 
> It's not 348586. I see the problem, and I am *positive* I ran the tests before
> I checked in, so I'm looking to see if something else bit me 

15 Aug 2006 19:08 PDT is OK. This is right before Brendan's checkin.

    
    

    
  
(In reply to comment #11)
>
> 15 Aug 2006 19:08 PDT is OK. This is right before Brendan's checkin.
> 

Feeds are broken on 15 Aug 2006 22:11 PDT, just after Brendan's checkin.

    
    

    
  


  
drivers: I had to back this out yesterday morning because a regression from js-engine bug 336379 bit me.

        Attachment #231487 -
        Attachment is obsolete: true

        Attachment #234316 -
        Flags: approval1.8.1?

    
    

    
  
Comment on attachment 234316 [details] [diff] [review]
new patch, no bitrot

vlad: drivers want a fresh review here just to be safe. The only difference is uuids and commented out logging.

        Attachment #234316 -
        Flags: review?(vladimir)

    
    

    
  
Comment on attachment 234316 [details] [diff] [review]
new patch, no bitrot

yep, looks fine; thanks for making the uuid changes!

        Attachment #234316 -
        Flags: review?(vladimir) → review+

    
    

    
  
Comment on attachment 234316 [details] [diff] [review]
new patch, no bitrot

a=schrep since previous patch was approved and regression is fixed.  Is this as is on trunk?

        Attachment #234316 -
        Flags: approval1.8.1? → approval1.8.1+

    
    

    
  
(In reply to comment #16)
> (From update of attachment 234316 [details] [diff] [review] [edit])
> a=schrep since previous patch was approved and regression is fixed.  Is this as
> is on trunk?
> 

Yes.

    
  
Whiteboard: [checkin needed(1.8.1)]

    
    

    
  
I checked in the first part of this for 1.8.1, so no checkin needed
Whiteboard: [checkin needed(1.8.1)]

    
    

    
  
Marking fixed1.8.1 per comment 18

Keywords: fixed1.8.1

    
    

    
  


  
reading sheppy's docs, I realized extension authors need a quick way to parse a feed by sending a GET to a URI (we don't need one in Firefox, suprisingly). Don't need all the detail of XmlHttpRequest, because this facility isn't very general.

        Attachment #237688 -
        Flags: review?(vladimir)

    
  

        Attachment #237688 -
        Flags: review?(vladimir)

    
    

    
  
I'll open up new bugs when the API is improved.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED

    
  
Product: Firefox → Firefox Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: