Closed Bug 340669 Opened 18 years ago Closed 18 years ago

nsISHistory required for View Source (undefined for Thunderbird)

Categories

(Toolkit :: View Source, defect)

Product:
Toolkit
Component:
View Source
Version:
1.8 Branch
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.8.1beta1

People

(Reporter: zeniko, Assigned: zeniko)

Details

(Keywords: fixed1.8.1)

Attachments

(1 file)

disable session history for view source
2.00 KB, patch
mconnor
: review+
mconnor
: approval-branch-1.8.1+
Details | Diff | Splinter Review 
Warning: reference to undefined property Components.interfaces.nsISHistory
Source file: chrome://global/content/bindings/browser.xml
Line: 548

Fixed for the suite in bug 229995 (attachment 138355 [details] [diff] [review] still applies).
The alternative would be to add a check for the existence of this interface to the <browser/> binding.
Attachment #224688 - Flags: review?(mconnor)
Attachment #224688 - Flags: review?(mconnor) → review+
Attachment #224688 - Flags: approval-branch-1.8.1?(mconnor)
Attachment #224688 - Flags: approval-branch-1.8.1?(mconnor) → approval-branch-1.8.1+
Status: NEW → ASSIGNED
Whiteboard: [checkin needed]
Assignee: nobody → zeniko
Status: ASSIGNED → NEW
mozilla/toolkit/components/viewsource/content/viewPartialSource.xul 	1.20.2.4
mozilla/toolkit/components/viewsource/content/viewSource.xul 	1.24.2.6

mozilla/toolkit/components/viewsource/content/viewPartialSource.xul 	1.24
mozilla/toolkit/components/viewsource/content/viewSource.xul 	1.31
Status: NEW → RESOLVED
Closed: 18 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Target Milestone: --- → Firefox 2 beta1
Version: unspecified → 2.0 Branch
Do we know why tbird isn't shipping nsISHistory? That's part of the docshell and should be available. Perhaps shistory.xpt isn't in the packaging lists?
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: