340743 - In FAYT mode after failed search, hitting F3 (Find Again) switches find bar UI to non-minimal UI

Status: RESOLVED FIXED

(Toolkit :: Find Toolbar, defect)

Description

[Jeff Walden [:Waldo]]

Something I didn't notice in bug 337654...

In FAYT, hit F3 to see the next result -- UI switches to the generalized search UI.  Worse, the timeout still fires, because find UI doesn't directly correlate with the current find mode, and the find bar (the non-minimalist version) disappears at timeout.

Comment 1

[Jeff Walden [:Waldo]]

This should have been done right the first time... :-\

Comment 2

[Peter Kasting]

Once this is fixed, it may be true that bug 256420 is INVALID.

Comment 3

[Jeff Walden [:Waldo]]

Attachment: Patch

The reason the line in delayedCloseFindBar has to be removed is that if you do a quick find for an unfound string, let the bar disappear, and then hit F3 to trigger onFindAgainCmd, the bar returns, but a close timeout is only set |if (this.mFindMode != FIND_NORMAL)|.  Consequently, the bar doesn't disappear on its own and can't be removed in any normal way by the user.

I audited the mFindMode callers to double-check that removing the line is okay, and nobody seems to be relying on this behavior, so it should be okay to remove it.

Comment 4

[Jeff Walden [:Waldo]]

Fixed on branch and trunk (with the addition of a missing |this.| in the final chunk of the patch).