34094 - no windows appear after profile manager is dismissed

Status: VERIFIED FIXED

(SeaMonkey :: General, defect, P1)

Description

[Kathleen :Brade]

On Mac, no matter how you dismiss the profile manager (keystroke or mouseclick), 
and no matter if you create a new profile or not, you don't get any windows.

Comment 1

[Simon Fraser [no longer active]]

Sounds like a XUL issue to me. Console output, brade?

Comment 2

[Patrick C. Beard]

I've got a fix for this in my tree. The idea is to only create 1 nsToolkit per 
thread, as rpotts did on Windows. Otherwise, we seem to have a problem where the 
nsToolkit repeater that processes PLEvents gets shut off, and events no longer 
get processed. Here're the patches:

Index: mozilla/widget/src/mac/nsAppShell.h
===================================================================
RCS file: /cvsroot/mozilla/widget/src/mac/nsAppShell.h,v
retrieving revision 1.24
diff -r1.24 nsAppShell.h
35a36
> #include "nsCOMPtr.h"
41c42
< class nsToolkit;
---
> class nsIToolkit;
55c56
<     auto_ptr<nsToolkit>            mToolKit;
---
>     nsCOMPtr<nsIToolkit>           mToolkit;

Index: mozilla/widget/src/mac/nsAppShell.cpp
===================================================================
RCS file: /cvsroot/mozilla/widget/src/mac/nsAppShell.cpp,v
retrieving revision 1.34
diff -r1.34 nsAppShell.cpp
80c80,83
< 	mToolKit = auto_ptr<nsToolkit>( new nsToolkit() );
---
> 	nsresult rv;
> 	rv = NS_GetCurrentToolkit(getter_AddRefs(mToolkit));
> 	if (NS_FAILED(rv))
> 		return rv;
82c85,86
< 	mMacPump = auto_ptr<nsMacMessagePump>( new nsMacMessagePump(mToolKit.get(), 
mMacSink.get()) );
---
> 	nsIToolkit* toolkit = mToolkit.get();
> 	mMacPump = auto_ptr<nsMacMessagePump>( new nsMacMessagePump(static_cast<
nsToolkit*>(toolkit), mMacSink.get()) );

Comment 3

[Jon Granrose]

sweet.  get it reviewed, check it in.  a=granrose

Comment 4

[Patrick C. Beard]

Fixes have been checked in.

Comment 5

[Asa Dotzler [:asa]]

verified fixed with 062808 build OS 9