no windows appear after profile manager is dismissed

VERIFIED FIXED in M15

Status

defect
P1
blocker
VERIFIED FIXED
19 years ago
15 years ago

People

(Reporter: Brade, Assigned: beard)

Tracking

({smoketest})

Trunk
PowerPC
Mac System 8.5

Firefox Tracking Flags

(Not tracked)

Details

Reporter

Description

19 years ago
On Mac, no matter how you dismiss the profile manager (keystroke or mouseclick), 
and no matter if you create a new profile or not, you don't get any windows.
Reporter

Updated

19 years ago
Severity: normal → blocker
Keywords: smoketest
Priority: P3 → P1
Target Milestone: --- → M15
Sounds like a XUL issue to me. Console output, brade?
Assignee

Comment 2

19 years ago
I've got a fix for this in my tree. The idea is to only create 1 nsToolkit per 
thread, as rpotts did on Windows. Otherwise, we seem to have a problem where the 
nsToolkit repeater that processes PLEvents gets shut off, and events no longer 
get processed. Here're the patches:

Index: mozilla/widget/src/mac/nsAppShell.h
===================================================================
RCS file: /cvsroot/mozilla/widget/src/mac/nsAppShell.h,v
retrieving revision 1.24
diff -r1.24 nsAppShell.h
35a36
> #include "nsCOMPtr.h"
41c42
< class nsToolkit;
---
> class nsIToolkit;
55c56
<     auto_ptr<nsToolkit>            mToolKit;
---
>     nsCOMPtr<nsIToolkit>           mToolkit;

Index: mozilla/widget/src/mac/nsAppShell.cpp
===================================================================
RCS file: /cvsroot/mozilla/widget/src/mac/nsAppShell.cpp,v
retrieving revision 1.34
diff -r1.34 nsAppShell.cpp
80c80,83
< 	mToolKit = auto_ptr<nsToolkit>( new nsToolkit() );
---
> 	nsresult rv;
> 	rv = NS_GetCurrentToolkit(getter_AddRefs(mToolkit));
> 	if (NS_FAILED(rv))
> 		return rv;
82c85,86
< 	mMacPump = auto_ptr<nsMacMessagePump>( new nsMacMessagePump(mToolKit.get(), 
mMacSink.get()) );
---
> 	nsIToolkit* toolkit = mToolkit.get();
> 	mMacPump = auto_ptr<nsMacMessagePump>( new nsMacMessagePump(static_cast<
nsToolkit*>(toolkit), mMacSink.get()) );

Comment 3

19 years ago
sweet.  get it reviewed, check it in.  a=granrose
Assignee

Comment 4

19 years ago
Fixes have been checked in.
Status: NEW → RESOLVED
Last Resolved: 19 years ago
Resolution: --- → FIXED

Comment 5

19 years ago
verified fixed with 062808 build OS 9
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.