Color picker displays grey [DlgFace] for "no color selected" (misleading: default color, typically black, gets used)

NEW
Unassigned

Status

--
minor
13 years ago
10 years ago

People

(Reporter: csthomas, Unassigned)

Tracking

Trunk
x86
Windows XP

Firefox Tracking Flags

(Not tracked)

Details

/mailnews/mailnews.js, line 121 -- pref("mail.citation_color", ""); // quoted color

By default, whenever I change the browser text color, quoted text changes with it, since there is no value set for the citation color.  If I change the quoted text color, there's no way to get back to "same as browser text" through the UI.  I think it would make sense to either set a default citation color matching the default browser.display.foreground_color, or have a "same as other text" option.

The pref window currently lies too, since the colorpicker appears grayish (same color as dialog box background) for me right now thanks to the blank color attribute, even though quoted text is black.

Comment 1

13 years ago
These same issues apply for all the color prefs with color-picker UI: the 
"HTML Messages" display colors:
  browser.display.background_color
  browser.display.foreground_color
and the Composition | HTML Settings colors:
  msgcompose.background_color
  msgcompose.text_color

viz these last two, xref bug 206219 comment 2.

Comment 2

12 years ago
Resummarizing, see TB bug 352869.

I think the "no color" selection should use a pattern, maybe a crosshatch.

The other issue is there's no way from the UI to pick "Use default color".
Severity: normal → minor
Summary: Quoted text color preference behavior is not good, pref window lies → Color picker display for "no color selected" is in fact grey (conflicts with typical default 'black' that gets used)
Are you sure that's correct?  Isn't the default "nothing", rather than gray?

Comment 4

12 years ago
I'm sure that the color picker displays grey when no color is selected, which is what I thought the summary said.  I'll make that a little clearer.
Well, OK, on my system, it actually displays light-blue, which is the background color I use for dialogs.

Better?
Summary: Color picker display for "no color selected" is in fact grey (conflicts with typical default 'black' that gets used) → Color picker displays grey [DlgFace] for "no color selected" (misleading: default color, typically black, gets used)
(In reply to comment #4)
> I'm sure that the color picker displays grey when no color is selected, which
> is what I thought the summary said.  I'll make that a little clearer.
> Well, OK, on my system, it actually displays light-blue, which is the
> background color I use for dialogs.
> 
> Better?
> 

Wouldn't that imply it's transparent?  If you change the dialog's color using DOMI, I'd expect it to show that new color.

Comment 6

12 years ago
Dude, change it to whatever you want.  Nobody's going to fix it anyway, you might as well make yourself feel better by wanking about word choice.
You need to log in before you can comment on or make changes to this bug.