341084 - layout/inspector uses AssignWithConversion strangely

Status: NEW

(Core :: Layout, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

The code here that uses AssignWithConversion could just use a unicode buffer directly.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 2

[Boris Zbarsky [:bzbarsky]]

Er... so what is this code actually doing?  Should it be calling a chrome registry API instead or something?

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 225151 [details] [diff] [review]
patch

Patch's ok as far as it goes, but I still think the code is just bogus in general...

Comment 4

[[e-mail]]

(In reply to comment #2)
>Er... so what is this code actually doing?
It looks as if it's converting a suite chrome URL into a CVS path e.g.
chrome://global/skin/icons/close.gif into global/icons/close.gif

Comment 5

[Boris Zbarsky [:bzbarsky]]

Any idea why? And whether that even makes sense for Firefox, say?

Comment 6

[[e-mail]]

(In reply to comment #5)
>Any idea why?
junkImgs.xml, "Find Unused Images in Current Theme", seems to be the consumer.
>And whether that even makes sense for Firefox, say?
Now that I think about it a bit more, it probably does.

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

patch checked in. other than that, I don't really want to have anything to do with this function, so -> default owner

Checking in layout/inspector/src/inCSSValueSearch.cpp;
/cvsroot/mozilla/layout/inspector/src/inCSSValueSearch.cpp,v  <--  inCSSValueSearch.cpp
new revision: 1.26; previous revision: 1.25
done