layout/inspector uses AssignWithConversion strangely

NEW
Unassigned

Status

()

Core
Layout
12 years ago
11 months ago

People

(Reporter: Biesinger, Unassigned)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

The code here that uses AssignWithConversion could just use a unicode buffer directly.
Created attachment 225151 [details] [diff] [review]
patch
Attachment #225151 - Flags: superreview?(bzbarsky)
Attachment #225151 - Flags: review?(bzbarsky)
Status: NEW → ASSIGNED
OS: Linux → All
Hardware: PC → All
Target Milestone: --- → mozilla1.9alpha
Er... so what is this code actually doing?  Should it be calling a chrome registry API instead or something?
Comment on attachment 225151 [details] [diff] [review]
patch

Patch's ok as far as it goes, but I still think the code is just bogus in general...
Attachment #225151 - Flags: superreview?(bzbarsky)
Attachment #225151 - Flags: superreview+
Attachment #225151 - Flags: review?(bzbarsky)
Attachment #225151 - Flags: review+

Comment 4

12 years ago
(In reply to comment #2)
>Er... so what is this code actually doing?
It looks as if it's converting a suite chrome URL into a CVS path e.g.
chrome://global/skin/icons/close.gif into global/icons/close.gif
Any idea why? And whether that even makes sense for Firefox, say?

Comment 6

12 years ago
(In reply to comment #5)
>Any idea why?
junkImgs.xml, "Find Unused Images in Current Theme", seems to be the consumer.
>And whether that even makes sense for Firefox, say?
Now that I think about it a bit more, it probably does.
patch checked in. other than that, I don't really want to have anything to do with this function, so -> default owner

Checking in layout/inspector/src/inCSSValueSearch.cpp;
/cvsroot/mozilla/layout/inspector/src/inCSSValueSearch.cpp,v  <--  inCSSValueSearch.cpp
new revision: 1.26; previous revision: 1.25
done
Assignee: cbiesinger → nobody
Status: ASSIGNED → NEW
Target Milestone: mozilla1.9alpha → ---
You need to log in before you can comment on or make changes to this bug.