warning: 'virtual nsresult nsImageLoadingContent::OnStartRequest(imgIRequest*)' was hidden

RESOLVED FIXED in mozilla1.9alpha1

Status

()

Core
DOM
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: Biesinger, Assigned: Biesinger)

Tracking

Trunk
mozilla1.9alpha1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

/home/chb/mozilla/content/html/content/src/../../../base/src/nsImageLoadingContent.h:67: warning: 'virtual nsresult nsImageLoadingContent::OnStartRequest(imgIRequest*)' was hidden
/home/chb/mozilla/content/html/content/src/../../../base/src/nsObjectLoadingContent.h:108: warning:   by 'virtual nsresult nsObjectLoadingContent::OnStartRequest(nsIRequest*, nsISupports*)'
/home/chb/mozilla/content/html/content/src/../../../base/src/nsImageLoadingContent.h:67: warning: 'virtual nsresult nsImageLoadingContent::OnStopRequest(imgIRequest*, PRBool)' was hidden
/home/chb/mozilla/content/html/content/src/../../../base/src/nsObjectLoadingContent.h:108: warning:   by 'virtual nsresult nsObjectLoadingContent::OnStopRequest(nsIRequest*, nsISupports*, nsresult)'

This warning was introduced by dbaron in bug 321054, which added this function to imgIDecoderObserver.
Created attachment 225154 [details] [diff] [review]
patch
Attachment #225154 - Flags: superreview?(bzbarsky)
Attachment #225154 - Flags: review?(bzbarsky)
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.9alpha
Comment on attachment 225154 [details] [diff] [review]
patch

Nice
Attachment #225154 - Flags: superreview?(bzbarsky)
Attachment #225154 - Flags: superreview+
Attachment #225154 - Flags: review?(bzbarsky)
Attachment #225154 - Flags: review+
Checking in content/base/src/nsObjectLoadingContent.h;
/cvsroot/mozilla/content/base/src/nsObjectLoadingContent.h,v  <--  nsObjectLoadingContent.h
new revision: 1.14; previous revision: 1.13
done
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
No longer blocks: 336791
You need to log in before you can comment on or make changes to this bug.