3411 - View manager fails to check return values

Status: VERIFIED FIXED

(Core :: Layout, defect, P2)

Description

[Simon Fraser [no longer active]]

nsViewManager fails to check return values for some calls that can quite
easily fail. E.g. in nsViewManager::GetDrawingSurface(), the call to
aContext.CreateDrawingSurface() can fail, but the return value is
ignored. This caused us a nasty crashing bug on Mac.

Comment 1

[michaelp]

fixed in my local tree. i'll check it in when the tree opens. since this isn't
the cause of the crash (it would merely mask bad behavior elesewhere), it's
probably not a good idea to check it in until the other issues associated with
the crash have been addressed. unless, of course, we're so desperate to get the
tree open that we don't really care about fixing the real bug... :)

Comment 2

[Pierre Saslawsky]

I agree: your fix shouldn't go into the tree before bug #3410 is fixed.

Comment 3

[Pierre Saslawsky]

A question though: when GetDrawingSurface() fails, we just draw directly on the
screen, right?

Comment 4

[michaelp]

that would be the correct thing to do yes. i'd have to look to make sure that
we correctly fall back today, but that is the idea. i'll make sure that this is
the case when i check in the first fix.

Comment 5

[Pierre Saslawsky]

*** Bug 3403 has been marked as a duplicate of this bug. ***

Comment 6

[Simon Fraser [no longer active]]

This bug should not have been closed as a dup of 3403. That bug addresses
the crash, the real cause of which was the NSPR memory leak. This bug relates
to the view manager failing to check return values, and I don't think michaelp
has checked in fixes there yet, so this bug should stay open until those changes
are checked in.

Comment 7

[michaelp]

i have no idea about the dup status, but i checked in view manager fixes
yesterday. you guys can sort it out from here...

Comment 8

[Simon Fraser [no longer active]]

I stand corrected. Closing again.

Comment 9

[Chris Petersen]

Fixed in March 9th Build.