Closed Bug 341154 Opened 14 years ago Closed 14 years ago

calIIcalProperty icalString attribute

Categories

(Calendar :: Internal Components, enhancement)

enhancement
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: dbo, Assigned: dbo)

References

Details

Attachments

(1 file, 2 obsolete files)

Attribute to get the whole ical property object as an escaped string.
Attachment #225186 - Flags: first-review?(dmose)
Attachment #225186 - Attachment is obsolete: true
Attachment #225186 - Flags: first-review?(dmose)
revised patch to apply again
Attachment #225570 - Flags: first-review?(dmose)
Attachment #225570 - Attachment is obsolete: true
Attachment #225570 - Flags: first-review?(dmose)
Attachment #225579 - Flags: first-review?(dmose)
Can you post the WCAP provider code somewhere so it's possible to see what situations this is used in?
(In reply to comment #4)
> Can you post the WCAP provider code somewhere so it's possible to see what
> situations this is used in?

I had a look at the current code and see that this new attribute is currently (only) used for logging. I needed it some months ago and introduced it; IMO it is likely to be used again (because the sun server takes arguments in ical mimic) and a sensible enhancement.
Dan, I would like check in the code, but still need to know whether it is ok to add provider specific IDL to base/public, i.e.
- error codes to calIErrors
- calIFreeBusyEntry
- calIFreeBusyListener
- calIWCapCalendar
before checking in.
(In reply to comment #5)
> Dan, I would like check in the code, but still need to know whether it is ok
> to add provider specific IDL to base/public

I'll try and save Dan some keystrokes here.
I believe that rather than checking in, what he was suggesting was to create a diff and post it somewhere for him to be able to look at.
(In reply to comment #6)
> (In reply to comment #5)
> > Dan, I would like check in the code, but still need to know whether it is ok
> > to add provider specific IDL to base/public
> 
> I'll try and save Dan some keystrokes here.
> I believe that rather than checking in, what he was suggesting was to create a
> diff and post it somewhere for him to be able to look at.
> 

Done. Please follow up in issue 340949.
Status: NEW → ASSIGNED
Comment on attachment 225579 [details] [diff] [review]
revised calIIcalPropery icalString

> NS_IMETHODIMP
>+calIcalProperty::GetIcalString(nsACString &str)
>+{
>+    char const* icalstr = icalproperty_as_ical_string(mProperty);
>+    if (icalstr == 0) {
>+#ifdef DEBUG
>+        fprintf(stderr, "Error getting ical string: %d (%s)\n",
>+                icalerrno, icalerror_strerror(icalerrno));
>+#endif
>+        return NS_ERROR_FAILURE;

If you would, use

 return calIErrors::ICS_ERROR_BASE + icalerrno;

and also add an @exception clause to the IDL documentation making it clear that any libical error will be thrown as an exception.

r=dmose with that fixed

Thanks for the patch.
Attachment #225579 - Flags: first-review?(dmose) → first-review+
landed.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.