341179 - [Mac] Menuitems should blink when selected

Status: RESOLVED INVALID

(Core Graveyard :: Widget: Mac, defect)

Description

[Håkan Waara]

Tested on BonEcho a3, Mac OS X 10.4.6.  Not sure if the bug exists on Cocoafox as well.

To test:

Choose the Firefox > Preferences menuitem.

Result:

Once the menuitem is selected, the menu disappears, and the prefs window opens.

Expected result:

The menuitem blinks a few times first (possibly according to a system pref, if such a pref exists) and the prefs window is then shown.

Comment 1

[Håkan Waara]

Works fine in Firefox-cocoa, so maybe this can be closed (as widget/mac is as good as deprecated in a short while).

Comment 2

[Josh Aas]

yeah, cocoa widgets should fix this

Comment 3

[Josh Aas]

Attachment: sorta fix v1.0

I'm just throwing this patch up here for now since one effect of it is to make blinking menus work better. This fixes some stuff in Carbon 1.8 branch menu code, but I'm not sure its the right thing to do right now, still sitting on it.

Comment 4

[Josh Aas]

Attachment: sorta fix v1.1

This version includes a file I forgot to fix last time and another fix from Cocoa widget code.

Comment 5

[Josh Aas]

I mean it includes a file I forgot to diff last time...

Comment 6

[Josh Aas]

Comment on attachment 228435 [details] [diff] [review]
sorta fix v1.1

I filed bug 343880 for my patch, this bug is actually about something that my patch doesn't fix.

Comment 7

[Mark Mentovai]

*** This bug has been marked as a duplicate of 66120 ***

Comment 8

[Mark Mentovai]

(back to comment 0)

Something about SetMenuFlashCount

Comment 9

[Mark Mentovai]

SetMenuFlashCount is weird.  SetMenuFlashCount(0) does what's advertised: it prevents the menu from fading out at all.  SetMenuFlashCount(anything_else) usually makes the first actuated item flash, and then doesn't seem to have much of a reliable effect after that.

Comment 10

[Mark Mentovai]

I reliably see menu item flashing on x86 Macs, without any changes at all.  I don't see flashing on ppc Macs.  Apple bug?

Comment 11

[Josh Aas]

I can confirm - menu item blinking works fine on Intel but not PPC. I'll file a bug with Apple.

Comment 12

[Mark Mentovai]

Apple bug, and we don't care about Carbon widgets enough at this point to do anything about it.