341180 - [Mac] Most widgets shouldn't steal focus on click

Status: RESOLVED DUPLICATE of bug 418521

(Core :: XUL, defect)

Description

[Håkan Waara]

Tested on BonEcho a3, Mac OS X 10.4.6

When clicking a button, or popupmenu, the focus should not change to that. On mac, the focus represents the *keyboard* focus.

Only a textfield or listbox/tree should receive keyboard focus (aka "first responder" in Cocoa-jargon) when clicked.

Clicks on other widgets should not give it keyboard focus.

Comment 1

[Håkan Waara]

Attachment: First draft of a fix

This patch fixes most of this bug. There's one case where it's not working yet though: if I have a checkbox and a button next to each other, and the checkbox has focus, clicking the button will make the focus ring go away from the checkbox. The button doesn't receive it though.

I'll need to find out why the checkbox gets a blur event, even though focus doesn't change (or isn't supposed to, at least).

Comment 2

[Håkan Waara]

Another to do is find all instances of trees/textfields and make them focusable.

Comment 3

[Håkan Waara]

Actually, thinking about it, IsFocusable() might not be the right/only place to hook into. I'll have to debug it more to see who's really in charge of changing focus on click.   If you have any ideas, let me know.

Comment 4

[Boris Zbarsky [:bzbarsky]]

How about ccing the focus experts?

Comment 5

[Aaron Leventhal]

Oliver Yeoh has to be included as one of the focus experts now. He's been active and fixed a few tough bugs recently.

Also, all focus bugs should be marked as blocking bug 83552, aka "focusnav".