341268 - Abstract autocomplete storage/retrieval strategy into a search-internal API using storage

Status: RESOLVED WORKSFORME

(Firefox :: Search, defect)

Description

[Jeff Walden [:Waldo]]

Currently autocomplete results are stored directly in Satchel, which is convenient but means that there's no easy way to remove only those autocomplete results created by the search bar (because no such way exists in nsIFormHistory2, or at least not in the Mork impl).  We should create a small internal API to abstract away the details of storing this information and implement it using storage.

See also bug 323966 comment 10.

Comment 1

[Mark Banner (:standard8)]

If we want to do this, it is now possible based on https://searchfox.org/mozilla-central/rev/928742d3ea30e0eb4a8622d260041564d81a8468/browser/components/search/test/browser/browser_searchbar_keyboard_navigation.js#36

I did look at morphing to include splitting into multiple options as bug 323966 implies, however, Marco tells me we're currently trying to reduce the amount of data sanitisation options at the moment.

Therefore I'll mark this as works for me.