Generator-iterator tests for JS1.7

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: Waldo, Assigned: Waldo)

Tracking

Trunk
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

I have some tests written that exercise iterators, generators, |Iterator|, and |__iterator__|.  Uploading in a sec...
Created attachment 225327 [details]
zip of testcases written so far

Trunk currently passes all these tests.  JS_1_7_ALPHA_BRANCH seems to have a couple bugs in it related to infinite loops and throwing StopIteration too soon.

What needs to be done to get these checked in and in use by people other than just me?

Comment 2

12 years ago
I'll take a look at these later tonight and if there aren't any issues, I'll take care of getting them in the tree. Thanks Jeff!

Comment 3

12 years ago
Created attachment 225479 [details]
test results trunk 2006061213 winxp

Here are the results of running the tests in browser and shell. We get a number of crashes in windows during the browser tests. :-( I will check the tests into the js test library as soon as the tree reopens.

Comment 4

12 years ago
Blake, Can you take a look at bug 340036? It is needed to handle the versioning properly. It should be very similar to what was done for 1.6 in bug 307315.
Blocks: 336373
Depends on: 340036

Comment 5

12 years ago
Thanks again Jeff. I really appreciate your work on this.

Checking in the js test library infrastructure. 

Checking in README;
/cvsroot/mozilla/js/tests/js1_7/README,v  <--  README
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/js/tests/js1_7/browser.js,v
done
Checking in browser.js;
/cvsroot/mozilla/js/tests/js1_7/browser.js,v  <--  browser.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/js/tests/js1_7/shell.js,v
done
Checking in shell.js;
/cvsroot/mozilla/js/tests/js1_7/shell.js,v  <--  shell.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/js/tests/js1_7/template.js,v
done
Checking in template.js;
/cvsroot/mozilla/js/tests/js1_7/template.js,v  <--  template.js
initial revision: 1.1
done

cvs add: use 'cvs commit' to add these files permanently
RCS file: /cvsroot/mozilla/js/tests/js1_7/geniter/326466-01.js,v
done
Checking in geniter/326466-01.js;
/cvsroot/mozilla/js/tests/js1_7/geniter/326466-01.js,v  <--  326466-01.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/js/tests/js1_7/geniter/browser.js,v
done
Checking in geniter/browser.js;
/cvsroot/mozilla/js/tests/js1_7/geniter/browser.js,v  <--  browser.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/js/tests/js1_7/geniter/builtin-Iterator-function.js,v
done
Checking in geniter/builtin-Iterator-function.js;
/cvsroot/mozilla/js/tests/js1_7/geniter/builtin-Iterator-function.js,v  <--  builtin-Iterator-function.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/js/tests/js1_7/geniter/fibonacci-matrix-generator.js,v
done
Checking in geniter/fibonacci-matrix-generator.js;
/cvsroot/mozilla/js/tests/js1_7/geniter/fibonacci-matrix-generator.js,v  <--  fibonacci-matrix-generator.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/js/tests/js1_7/geniter/iterator-toString.js,v
done
Checking in geniter/iterator-toString.js;
/cvsroot/mozilla/js/tests/js1_7/geniter/iterator-toString.js,v  <--  iterator-toString.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/js/tests/js1_7/geniter/message-value-passing.js,v
done
Checking in geniter/message-value-passing.js;
/cvsroot/mozilla/js/tests/js1_7/geniter/message-value-passing.js,v  <--  message-value-passing.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/js/tests/js1_7/geniter/multiple-close.js,v
done
Checking in geniter/multiple-close.js;
/cvsroot/mozilla/js/tests/js1_7/geniter/multiple-close.js,v  <--  multiple-close.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/js/tests/js1_7/geniter/nested-yield.js,v
done
Checking in geniter/nested-yield.js;
/cvsroot/mozilla/js/tests/js1_7/geniter/nested-yield.js,v  <--  nested-yield.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/js/tests/js1_7/geniter/pi-generator.js,v
done
Checking in geniter/pi-generator.js;
/cvsroot/mozilla/js/tests/js1_7/geniter/pi-generator.js,v  <--  pi-generator.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/js/tests/js1_7/geniter/send-no-rhs.js,v
done
Checking in geniter/send-no-rhs.js;
/cvsroot/mozilla/js/tests/js1_7/geniter/send-no-rhs.js,v  <--  send-no-rhs.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/js/tests/js1_7/geniter/sequential-yields.js,v
done
Checking in geniter/sequential-yields.js;
/cvsroot/mozilla/js/tests/js1_7/geniter/sequential-yields.js,v  <--  sequential-yields.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/js/tests/js1_7/geniter/shell.js,v
done
Checking in geniter/shell.js;
/cvsroot/mozilla/js/tests/js1_7/geniter/shell.js,v  <--  shell.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/js/tests/js1_7/geniter/simple-fib.js,v
done
Checking in geniter/simple-fib.js;
/cvsroot/mozilla/js/tests/js1_7/geniter/simple-fib.js,v  <--  simple-fib.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/js/tests/js1_7/geniter/throw-after-close.js,v
done
Checking in geniter/throw-after-close.js;
/cvsroot/mozilla/js/tests/js1_7/geniter/throw-after-close.js,v  <--  throw-after-close.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/js/tests/js1_7/geniter/throw-forever.js,v
done
Checking in geniter/throw-forever.js;
/cvsroot/mozilla/js/tests/js1_7/geniter/throw-forever.js,v  <--  throw-forever.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/js/tests/js1_7/geniter/unreachable-yield.js,v
done
Checking in geniter/unreachable-yield.js;
/cvsroot/mozilla/js/tests/js1_7/geniter/unreachable-yield.js,v  <--  unreachable-yield.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/js/tests/js1_7/geniter/yield-undefined.js,v
done
Checking in geniter/yield-undefined.js;
/cvsroot/mozilla/js/tests/js1_7/geniter/yield-undefined.js,v  <--  yield-undefined.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/js/tests/js1_7/iterable/basic-Iterator.js,v
done
Checking in iterable/basic-Iterator.js;
/cvsroot/mozilla/js/tests/js1_7/iterable/basic-Iterator.js,v  <--  basic-Iterator.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/js/tests/js1_7/iterable/basic-for-each.js,v
done
Checking in iterable/basic-for-each.js;
/cvsroot/mozilla/js/tests/js1_7/iterable/basic-for-each.js,v  <--  basic-for-each.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/js/tests/js1_7/iterable/basic-for-in.js,v
done
Checking in iterable/basic-for-in.js;
/cvsroot/mozilla/js/tests/js1_7/iterable/basic-for-in.js,v  <--  basic-for-in.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/js/tests/js1_7/iterable/browser.js,v
done
Checking in iterable/browser.js;
/cvsroot/mozilla/js/tests/js1_7/iterable/browser.js,v  <--  browser.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/js/tests/js1_7/iterable/shell.js,v
done
Checking in iterable/shell.js;
/cvsroot/mozilla/js/tests/js1_7/iterable/shell.js,v  <--  shell.js
initial revision: 1.1
done

Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED

Updated

12 years ago
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.