Closed Bug 341403 Opened 14 years ago Closed 14 years ago

Sunbird: Make error if build with --enable-installer on Windows

Categories

(Calendar :: General, defect)

x86
Windows 2000
defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: ssitter, Assigned: ssitter)

Details

Attachments

(1 file)

Sunbird: Make error if build with --enable-installer on Windows

make[4]: Entering directory `/cygdrive/y/sb-trunk-rel/calendar/sunbird'
make[4]: *** No rule to make target `/cygdrive/y/dev/sb-trunk/mozilla/calendar/sunbird/installer/windows/Makefile.in', needed by `installer/windows/Makefile'.  Stop.
make[4]: Leaving directory `/cygdrive/y/sb-trunk-rel/calendar/sunbird'
make[3]: *** [export_tier_99] Error 2

The problem seems to be in /calendar/sunbird/Makefile.in:

    ifeq ($(OS_ARCH),WINNT)
    ifdef MOZ_INSTALLER
    DIRS += installer/windows
    endif
    endif

But there is no directory /calendar/sunbird/installer/windows. Instead there is only a directory /calendar/installer/windows.
Hmm. Regression from Universal Binaries change?

Stefan, can you add change "DIRS += installer..." to be "DIRS += ../installer..." and see if things work better?

Attached patch fix make errorSplinter Review
(In reply to comment #1)
> Hmm. Regression from Universal Binaries change?
I don't think so. The makefile was last changed begin of 2005. The problem seems to exist longer but until now the installer was always disabled in sunbirds mozconfig.

I replaced the line mentioned above with 'DIRS += ../installer/windows' and the build finished without problem. It does not produce an installer but that is not the scope of this bug. (Should be addressed later once Firefox and Thunderbird completed the new NSIS installer).
Assignee: nobody → ssitter
Status: NEW → ASSIGNED
Attachment #225742 - Flags: first-review?(jminta)
Comment on attachment 225742 [details] [diff] [review]
fix make error

this is definitely right, regardless of what else we do. r=jminta
Attachment #225742 - Flags: first-review?(jminta) → first-review+
patch checked in.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.