341403 - Sunbird: Make error if build with --enable-installer on Windows

Status: VERIFIED FIXED

(Calendar :: General, defect)

Description

[Stefan Sitter [:ssitter]]

Sunbird: Make error if build with --enable-installer on Windows

make[4]: Entering directory `/cygdrive/y/sb-trunk-rel/calendar/sunbird'
make[4]: *** No rule to make target `/cygdrive/y/dev/sb-trunk/mozilla/calendar/sunbird/installer/windows/Makefile.in', needed by `installer/windows/Makefile'.  Stop.
make[4]: Leaving directory `/cygdrive/y/sb-trunk-rel/calendar/sunbird'
make[3]: *** [export_tier_99] Error 2

The problem seems to be in /calendar/sunbird/Makefile.in:

    ifeq ($(OS_ARCH),WINNT)
    ifdef MOZ_INSTALLER
    DIRS += installer/windows
    endif
    endif

But there is no directory /calendar/sunbird/installer/windows. Instead there is only a directory /calendar/installer/windows.

Comment 1

[Matthew (lilmatt) Willis]

Hmm. Regression from Universal Binaries change?

Stefan, can you add change "DIRS += installer..." to be "DIRS += ../installer..." and see if things work better?

Comment 2

[Stefan Sitter [:ssitter]]

Attachment: fix make error

(In reply to comment #1)
> Hmm. Regression from Universal Binaries change?
I don't think so. The makefile was last changed begin of 2005. The problem seems to exist longer but until now the installer was always disabled in sunbirds mozconfig.

I replaced the line mentioned above with 'DIRS += ../installer/windows' and the build finished without problem. It does not produce an installer but that is not the scope of this bug. (Should be addressed later once Firefox and Thunderbird completed the new NSIS installer).

Comment 3

[Joey Minta]

Comment on attachment 225742 [details] [diff] [review]
fix make error

this is definitely right, regardless of what else we do. r=jminta

Comment 4

[Joey Minta]

patch checked in.