Closed
Bug 341438
Opened 19 years ago
Closed 19 years ago
nsMetricsService::ProfileStartup() doesn't finish on first run
Categories
(Toolkit Graveyard :: Data Collection/Metrics, defect)
Toolkit Graveyard
Data Collection/Metrics
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bryner, Assigned: bryner)
Details
Attachments
(1 file)
|
2.74 KB,
patch
|
Details | Diff | Splinter Review |
nsMetricsService::ProfileStartup() is a little too zealous about error-checking, so it returns early if the event count pref doesn't exist (which it won't, the first time the code is run).
|
Assignee | |
Comment 1•19 years ago
|
||
In addition to not checking the return value from GetIntPref, I removed the return code from EnableCollectors since it's not used for anything.
Attachment #225486 -
Flags: first-review?(marria)
|
|
||
Comment 2•19 years ago
|
||
Comment on attachment 225486 [details] [diff] [review]
patch
Just remove the printf and you're good to go
Attachment #225486 -
Flags: first-review?(marria) → first-review+
|
|
Assignee | |
Comment 3•19 years ago
|
||
checked in
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•