341458 - Implement --enable-libxul-devel configure option

Status: RESOLVED INVALID

(Firefox Build System :: General, enhancement)

Description

[Darin Fisher]

Implement --enable-libxul-devel configure option

See this thread for background:
http://groups.google.com/group/mozilla.dev.platform/browse_frm/thread/e1a7f955cac7dd81/b70abbec40331a3c

The plan is to add an --enable-libxul-devel configure option that results in the modules that make up libxul being built as dependent libraries.  This will make it easier to modify code in development trees because linking will take less time.  It will also facilitate more code sharing because we will stop building core modules as standalone XPCOM components.  For example, we will be able to have gklayout link directly against gkparser in a devel tree.

Comment 1

[Darin Fisher]

Attachment: v0.1 patch - prototype

This is just a check-point for implementing this build option.  I'm posting so that people can take a look and make suggestions.

Comment 2

[Darin Fisher]

I've only tested this patch on Linux.

Comment 3

[Benjamin Smedberg]

Comment on attachment 225812 [details] [diff] [review]
v0.1 patch - prototype

>Index: configure.in

>+LIBXUL_COMPONENT_LIBS='-L$(LIBXUL_DIST)/bin -lxpcom_core'

LIBXUL_INTERNAL_LIBS

>Index: js/jsd/Makefile.in

> ifdef MOZ_ENABLE_LIBXUL
> FORCE_SHARED_LIB=
> MODULE_NAME = JavaScript_Debugger
> endif
>+ifdef MOZ_ENABLE_LIBXUL_DEVEL
>+MODULE_NAME = JavaScript_Debugger
>+endif
> endif

This doesn't look necessary.

>Index: toolkit/library/libxul-config.mk

>-# dependent libraries
>-STATIC_LIBS += \
>+DEP_STATIC_LIBS = \

Could we perhaps not rename STATIC_LIBS and COMPONENT_LIBS, and instead rename the hunk set below? There are various patches floating around that are going to conflict terribly if we do the global rename here.

>+ifdef MOZ_ENABLE_LIBXUL
>+COMPONENT_LIBS += $(DEP_COMPONENT_LIBS)
>+STATIC_LIBS += $(DEP_STATIC_LIBS)
>+endif

ifdef MOZ_ENABLE_LIBXUL
LINK_COMPONENT_LIBS += $(COMPONENT_LIBS) 
LINK_STATIC_LIBS += $(STATIC_LIBS)

Comment 4

[Pawel Chmielowski]

Attachment: another prototype patch

This patch additionaly modifies ld script to export *_NSGetModule symbols, renames LIBXUL_COMPONENT_LIBS to LIBXUL_INTERNAL_LIBS, allows building xulrunner with new flag, and minimize changes in libxul-config.mk.

I tested it only on linux.

Comment 5

[Darin Fisher]

Pawel, thank you for the revised patch!

Comment 6

[Darin Fisher]

-> reassign to default owner

Comment 7

[Gregory Szorc [:gps]]

Pretty sure this bug became irrelevant once we moved to a monolithic libxul without any realistic option of going back.